Fix handling of parse errors when using include!().
#22054
Merged
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoTestard
force-pushed
the
include-parse-errors
branch
2 times, most recently
from
ded0ad0 to
2daf7ad
Compare
| // include file for issue-21146.rs | ||
| // not supposed to be tested alone | ||
|
|
||
| parse_error |
There was a problem hiding this comment.
We have auxiliary directories (or something along those lines) for stuff like this.
There was a problem hiding this comment.
Didn't know that. Fixed, thanks.
Makes the compilation abort when a parse error is encountered while trying to parse an item in an included file. The previous behaviour was to stop processing the file when a token that can't start an item was encountered, without producing any error. Fixes rust-lang#21146.
LeoTestard
force-pushed
the
include-parse-errors
branch
from
2daf7ad to
8f2ab66
Compare
bors
added a commit
that referenced
this pull request
Feb 8, 2015
Makes the compilation abort when a parse error is encountered while trying to parse an item in an included file. The previous behaviour was to stop processing the file when a token that can't start an item was encountered, without producing any error. Fixes #21146.
|
Perhaps the test should be placed in the newly created Or we can move it later as a rollup. Either works. |
|
Thank you so much <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the compilation abort when a parse error is encountered while
trying to parse an item in an included file. The previous behaviour was
to stop processing the file when a token that can't start an item was
encountered, without producing any error. Fixes #21146.