Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates(vercel): remove Vercel template in favor of official one #6784

Merged

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jul 7, 2023

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

⚠️ No Changeset found

Latest commit: f39f1e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the use-official-vercel-template branch from 0d716dc to 8a38262 Compare July 9, 2023 14:16
@brophdawg11
Copy link
Contributor

Let's keep this as is for now. We have some create-remix changes coming soon that will probably remove the dropdown list entirely.

@MichaelDeBoey
Copy link
Member Author

@brophdawg11 Since we already mention that people shouldn't use this template because of changes by the Vercel team (see #5964), I still pointing towards their official template is a good move

@MichaelDeBoey
Copy link
Member Author

@brophdawg11 Re-opening this as the mentioned changes will probably not land into v2

@MichaelDeBoey MichaelDeBoey reopened this Jul 20, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the use-official-vercel-template branch 3 times, most recently from 78af8f7 to ee69592 Compare July 21, 2023 15:48
@MichaelDeBoey MichaelDeBoey changed the title feat(remix-dev): use official Vercel template templates(vercel): remove Vercel template in favor of official one Jul 21, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the use-official-vercel-template branch from ee69592 to 6d77167 Compare July 22, 2023 19:20
@MichaelDeBoey MichaelDeBoey force-pushed the use-official-vercel-template branch 4 times, most recently from af5adb7 to 6e298cd Compare July 31, 2023 14:12
@brophdawg11
Copy link
Contributor

I think this is good to go - let's get conflicts resolved and we can get it merged for v2

@MichaelDeBoey MichaelDeBoey force-pushed the use-official-vercel-template branch from 6e298cd to 3e663b5 Compare August 1, 2023 18:06
@MichaelDeBoey
Copy link
Member Author

@brophdawg11 This should be good to go now

@MichaelDeBoey
Copy link
Member Author

@brophdawg11 Maybe it's still a good idea to mention the official Vercel one somewhere in the docs? 🤔

CC/ @markdalgleish Since you created the new Templates docs, I think you probably know best where to put this if we want to have it?

@MichaelDeBoey MichaelDeBoey force-pushed the use-official-vercel-template branch from 3e663b5 to f39f1e3 Compare August 1, 2023 23:39
@markdalgleish
Copy link
Member

@MichaelDeBoey I've opened a PR adding a third-party templates section to the docs: #7030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants