-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates(vercel): remove Vercel template in favor of official one #6784
templates(vercel): remove Vercel template in favor of official one #6784
Conversation
|
0d716dc
to
8a38262
Compare
Let's keep this as is for now. We have some |
@brophdawg11 Since we already mention that people shouldn't use this template because of changes by the Vercel team (see #5964), I still pointing towards their official template is a good move |
@brophdawg11 Re-opening this as the mentioned changes will probably not land into v2 |
78af8f7
to
ee69592
Compare
ee69592
to
6d77167
Compare
af5adb7
to
6e298cd
Compare
I think this is good to go - let's get conflicts resolved and we can get it merged for v2 |
6e298cd
to
3e663b5
Compare
@brophdawg11 This should be good to go now |
@brophdawg11 Maybe it's still a good idea to mention the official Vercel one somewhere in the docs? 🤔 CC/ @markdalgleish Since you created the new Templates docs, I think you probably know best where to put this if we want to have it? |
3e663b5
to
f39f1e3
Compare
@MichaelDeBoey I've opened a PR adding a third-party templates section to the docs: #7030 |
/~https://github.com/vercel/vercel/tree/main/examples/remix