Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-dev): use external Vercel template #5500

Closed
wants to merge 4 commits into from
Closed

feat(remix-dev): use external Vercel template #5500

wants to merge 4 commits into from

Conversation

Ethan-Arrowood
Copy link

This PR updates the template that remix uses when you call the create command. Wanted to propose this new solution where it will download the template we maintain. If y'all would like to still own the template I'd be happy to scrap these changes and just send a PR that copy-paste from our template.

Testing Strategy:

Template is tested in Vercel's repo's integration tests.

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6977e7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 17, 2023

Hi @Ethan-Arrowood,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 17, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@Ethan-Arrowood
Copy link
Author

Had to remove self temporarily from CLA. Don't expect it to be an issue but need to get explicit internal approval before I "sign" it. Whoops!

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 22, 2023
@github-actions github-actions bot closed this Apr 29, 2023
@remix-run remix-run deleted a comment from github-actions bot Apr 30, 2023
@remix-run remix-run deleted a comment from github-actions bot Apr 30, 2023
@machour machour reopened this Apr 30, 2023
@machour machour removed the needs-response We need a response from the original author about this issue/PR label Apr 30, 2023
@MichaelDeBoey
Copy link
Member

Hi @Ethan-Arrowood!

Are you still interested in getting this one merged?

If so, please rebase onto latest dev & resolve conflicts

@MichaelDeBoey MichaelDeBoey changed the title Fix Vercel Template feat(remix-dev): use external Vercel template May 2, 2023
@MichaelDeBoey MichaelDeBoey added package:dev template:vercel needs-response We need a response from the original author about this issue/PR labels May 2, 2023
@Ethan-Arrowood Ethan-Arrowood marked this pull request as ready for review May 10, 2023 18:48
@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label May 10, 2023
@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev May 16, 2023 17:48
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main May 16, 2023 17:49
MichaelDeBoey
MichaelDeBoey requested changes May 16, 2023
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ethan-Arrowood Since this is also a code change, could you please rebase onto latest dev & set base branch to dev as well?

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 16, 2023
@Ethan-Arrowood Ethan-Arrowood changed the base branch from main to dev May 16, 2023 20:24
@Ethan-Arrowood
Copy link
Author

Fixed up 👍

sergiodxa
sergiodxa approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@sergiodxa sergiodxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template being owned by Vercel the same way you own the adapter makes lots of sense 👍

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label May 16, 2023
@Ethan-Arrowood
Copy link
Author

Hi folks, whats the status on this? I fixed it up previously and it never merged. Now its conflicting again. If I fix the merge conflicts can we land this?

@Ethan-Arrowood
Copy link
Author

Fixed merge conflicts 👍 Lets get this merged 🚢

@pcattori pcattori assigned pcattori and unassigned pcattori Jul 10, 2023
@MichaelDeBoey
Copy link
Member

Superseded by #6784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey requested changes

@sergiodxa sergiodxa sergiodxa approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev template:vercel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ethan-Arrowood @MichaelDeBoey @sergiodxa @machour @pcattori