Add possibility to add multiple phpstan configs

[alexander-schranz]

Closes rectorphp/rector#8141

[samsonasik]

would be great to have both available imo, that's like $rectorConfig->rule() and $rectorConfig->rules()

[alexander-schranz]

@samsonasik Okay then we need to discuss the defaults of the following:

Case A: Using phpstanConfigs without phpstanConfig e.g.:

$rectorConfig->phpstanConfigs(['some-test.neon'])

Should the current default phpstan.neon still be loaded or not?

Case B: Using phpstanConfigs and phpstanConfig:

$rectorConfig->phpstanConfig('some-test.neon');
$rectorConfig->phpstanConfigs(['some-test.neon']);

Does phpstanConfigs overwrite phpstanConfig or not?

Case C: Using phpstanConfigs before phpstanConfig:

$rectorConfig->phpstanConfigs(['some-test.neon']);
$rectorConfig->phpstanConfig('some-test.neon');

Does phpstanConfig overwrite phpstanConfigs or not?

Case D: Multiple phpstanConfigs calls:

$rectorConfig->phpstanConfigs(['some-test.neon']);
$rectorConfig->phpstanConfigs(['some-other.neon']);

Does it replace or not load both?

Case E: Multiple phpstanConfig calls:

$rectorConfig->phpstanConfig('some-test.neon');
$rectorConfig->phpstanConfig('some-other.neon');

Does it replace or not load both?

[samsonasik]

I think the config should merge like when we define:

$rectorConfig->rule(FirstRector::class);

$rectorConfig->rules([
        SecondRector::class,
        ThirdRector::class,
]);

The result of rules are 3.

[alexander-schranz]

@samsonasik what I'm currently not understand how currently the fallback to phpstan.neon works if there is nothing configured.

[alexander-schranz]

Or is this comment here:

rector-src/packages/Config/RectorConfig.php

Line 137 in e7f5510

* By default, the "phpstan.neon" path is used.

not longer true?

[samsonasik]

That seems no longer true afaik

[samsonasik]

Looks good to me 👍

[staabm]

Could it be covered by a test?

[TomasVotruba]

@alexander-schranz Thank you 👍

[bloep]

@TomasVotruba do you see any chance that we can get a Rector release with this fix in the near future?
That would solve a pain point for us 🙏

[TomasVotruba]

@bloep Sure, I'm on it :)

[TomasVotruba]

There you /~https://github.com/rectorphp/rector/releases/tag/0.17.14 💪

[TomasVotruba]

I have just realized the container switch might be a BC break for anyone using Symfony internals (though they should not) 🤦

So I changed replaced the tag to a minor version jump, just to be sure:
/~https://github.com/rectorphp/rector/releases/tag/0.18.0

Use the Rector 0.18.0 tag instead. My appologies for confusion 🙏