Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHPStan] Avoid removing bleeding edge from phar include, let user handle own phpstan configuration #4840

Merged
merged 2 commits into from
Aug 23, 2023
Merged

[PHPStan] Avoid removing bleeding edge from phar include, let user handle own phpstan configuration #4840

merged 2 commits into from
Aug 23, 2023

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Aug 23, 2023 •
edited
Loading

Follow up to #4769, as Rector no longer autoloads all PHPStan configs

This is now handled fully by user configuration - #4798 👍


Ref 70fb9af

Ref rectorphp/rector#2431

@TomasVotruba TomasVotruba merged commit 75f2cbc into main Aug 23, 2023
@TomasVotruba TomasVotruba deleted the tv-less-bleeding branch August 23, 2023 15:32
@samsonasik samsonasik mentioned this pull request Aug 24, 2023
Merged
@samsonasik
Copy link
Member

@TomasVotruba it seems cause NodeConnectingVisitor enabled by default, I created PR:

to explicitely nodeConnectingVisitorCompatibility: false to disable NodeConnectingVisitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomasVotruba @samsonasik @actions-user