Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flags from file when available in OLCI NC reader #2767

Merged
merged 2 commits into from
Mar 27, 2024

Fix failing case

3aa2f79
Select commit
Loading
Failed to load commit list.
Merged

Use flags from file when available in OLCI NC reader #2767

Fix failing case
3aa2f79
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Mar 26, 2024 in 36s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

Annotations

Check notice on line 1 in satpy/tests/reader_tests/test_olci_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Code Duplication 

introduced similar code in: TestBitFlags.test_bitflags,TestBitFlags.test_bitflags_with_custom_flag_list,TestBitFlags.test_bitflags_with_dataarray_without_flags. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
View more details on CodeScene Delta Analysis