Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flags from file when available in OLCI NC reader #2767

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

mraspaud
Copy link
Member

This PR adds support for in-file flags masks and meanings in the olci-nc reader.

  • Tests added

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Mar 25, 2024
@mraspaud mraspaud self-assigned this Mar 25, 2024
@mraspaud mraspaud requested a review from djhoese as a code owner March 25, 2024 18:02
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (5ffe15e) to head (3aa2f79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2767   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         377      377           
  Lines       53489    53535   +46     
=======================================
+ Hits        51310    51356   +46     
  Misses       2179     2179           
Flag Coverage Δ
behaviourtests 4.10% <0.00%> (-0.01%) ⬇️
unittests 96.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8432424384

Details

  • 48 of 48 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 96.008%

Totals Coverage Status
Change from base Build 8350021041: 0.003%
Covered Lines: 51228
Relevant Lines: 53358

💛 - Coveralls

@mraspaud mraspaud merged commit 9952f39 into pytroll:main Mar 27, 2024
17 of 19 checks passed
@mraspaud mraspaud deleted the support-olci-flags-from-files branch March 27, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants