Add support for Cluster.AltStatName #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
suggested changes
Dec 10, 2018
Signed-off-by: tim <tim@fewagainstmany.com> Fix gofmt Signed-off-by: tim <tim@fewagainstmany.com>
|
@davecheney sorry about that. Hadn't realized that updating the the branch directly from Github UI would remove the sign-off. It's done now. |
|
I'm going to mark this for review in 0.9 -- after kubecon -- I don't want to merge this into 0.8.1 as it changes the statistics format that 0.8 customers may be relying on. |
|
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at providing a solution for #689
Goal: Add support for Cluster.AltStatName to expose a more readable stat name.
Note:
AltStatNamedoes not seem to have themaximum length of a cluster name is limited to 60limitation, so it is possible that the cluster name and the stat name differ slightly.Feedback welcome!