Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cluster.alt_stats_name #689

Closed
davecheney opened this issue Sep 19, 2018 · 7 comments
Closed

Implement cluster.alt_stats_name #689

davecheney opened this issue Sep 19, 2018 · 7 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
0.9.0

Comments

@davecheney
Copy link
Contributor

Currently per cluster statistics are emitted with the name of the cluster. Prior to #581 this would be the pseudo name namespace/name/portnum. After #581, the pseudo name is namespace/name/portnum/hash.

We can use cluster.alt_stats_name to normalise the reporting of statistics to the namespace,name,portnum tuple, or even to the namespace,name tuple.
@davecheney davecheney added this to the 0.7.0 milestone Sep 19, 2018
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 19, 2018
@davecheney
Copy link
Contributor Author

Note to implementers; doing this work is straight forward, but please do not proceed without a clear decision on the format of the alternative name for statistics.

@seancrwhite
Copy link

Hi there, is anyone currently looking at this? I'd like to contribute and think this would be a good place for me to start.

@davecheney
Copy link
Contributor Author

@seancrwhite got for it; but please get agreement from @rosskukulinski and @alexbrand on the format for the name before sending a PR. Thanks.

@seancrwhite
Copy link

@davecheney will do!

@seancrwhite
Copy link

@rosskukulinski @alexbrand upon review I think namespace_name_portnum would be the best naming convention for these stats. Thoughts?

@rosskukulinski
Copy link
Contributor

@seancrwhite I'm on board with that naming convention

@davecheney davecheney modified the milestones: 0.7.0, 0.8.0 Oct 23, 2018
@davecheney
Copy link
Contributor Author

davecheney commented Oct 23, 2018 •
edited
Loading

Too late for 0.7. Please feel free to send a PR and mark it for review in 0.8

@davecheney davecheney modified the milestones: 0.8.0, 0.9.0 Nov 13, 2018
@pims pims mentioned this issue Dec 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
3 participants
@davecheney @rosskukulinski @seancrwhite