-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next,ui): improves loading states #6434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Significantly improves the loading states within the Admin Panel by avoiding rendering full screen loading overlays. To do this we needed to 1. load as much on the server as possible and 2. prevent Cumulative Layout Shift while streaming in components:
DocumentInfoProvider
from the server when navigating pages (no more calls to/api/form-state
on initial page load)initializing
state in theForm
componentDetermine main nav status server-side(update: impossible because of client-side media queries, we collapse on mobile by default so this is unavoidable)Overall, the admin panel now feels faster with less lag. BUT in the future we really ought to:
Link
component and tie into theuseTransition
API—but routing can originate from js-based events elsewhere and this pattern would not catch those events.