-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adapt Hunger Games to the ANN modification in Robotoff #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
teolemon
changed the title
fix: Adapt HG to the ANN modification in Robotoff
fix: Adapt Hunger Games to the ANN modification in Robotoff
Dec 24, 2022
merging then ? |
teolemon
added a commit
that referenced
this pull request
Jan 4, 2023
* Feat: New translations for Hunger Games (#404) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * cleaning (#402) * Allows inline logo editing * some cleaning * Feat: New translations for Hunger Games (#406) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: use predictor nutriscore for corresponding game (#407) * docs: readme-refactor (#410) * chore(deps-dev): bump husky from 8.0.1 to 8.0.2 (#382) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: allows to see packaging interface for specific products (#411) Fix #396 * fix: Adapt Hunger Games to the ANN modification in Robotoff (#409) * fix: change of API route to Robotoff ANN search * fix: Adding query_logo_id to results in ANN search * Feat: New translations for Hunger Games (#408) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: typo reported by Thomas (#421) * Feat: New translations for Hunger Games (#424) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Feat: New translations for Hunger Games (#426) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Feat: New translations for Hunger Games (#429) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Feat: Introduce dashboard page (#444) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com> Fix #327 * feat: dashboard galore * add new logos to dashboards * fix JS typo * fix some images * add "produced in britany" logo * remove duplicate * remove useless attributes * Update src/pages/logosValidator/dashboardDefinition.ts * trigger render * Update src/pages/logosValidator/dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Update src/pages/logosValidator/dashboardDefinition.ts * Update dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> * Update dashboardDefinition.ts * Update dashboardDefinition.ts * Update dashboardDefinition.ts * Update dashboardDefinition.ts * Update dashboardDefinition.ts * Update dashboardDefinition.ts Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gabriel Ben Zenou <gabriel.benzenou@student-cs.fr> Co-authored-by: alexandre <alex.fauquette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Important