-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allows to see packaging interface for specific products #411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's 💯 @alexfauquette
@@ -243,11 +244,16 @@ const Page = () => { | |||
const packagingMaterials = useOptions("packaging_materials", lang); | |||
const packagingShapes = useOptions("packaging_shapes", lang); | |||
const packagingRecycling = useOptions("packaging_recycling", lang); | |||
const [searchState] = useUrlParams({ | |||
country: "en:france", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would default this to world
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is to do as many as possible products for the french agency ADEM and open it to the world after that
It's kind of related to the issue asking to add a field country in the settings such that
* Feat: New translations for Hunger Games (#404) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * cleaning (#402) * Allows inline logo editing * some cleaning * Feat: New translations for Hunger Games (#406) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: use predictor nutriscore for corresponding game (#407) * docs: readme-refactor (#410) * chore(deps-dev): bump husky from 8.0.1 to 8.0.2 (#382) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: allows to see packaging interface for specific products (#411) Fix #396 * fix: Adapt Hunger Games to the ANN modification in Robotoff (#409) * fix: change of API route to Robotoff ANN search * fix: Adding query_logo_id to results in ANN search * Feat: New translations for Hunger Games (#408) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: typo reported by Thomas (#421) * Feat: New translations for Hunger Games (#424) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Feat: New translations for Hunger Games (#426) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Feat: New translations for Hunger Games (#429) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Feat: Introduce dashboard page (#444) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com> Fix #327 * feat: dashboard galore * add new logos to dashboards * fix JS typo * fix some images * add "produced in britany" logo * remove duplicate * remove useless attributes * Update src/pages/logosValidator/dashboardDefinition.ts * trigger render * Update src/pages/logosValidator/dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Update src/pages/logosValidator/dashboardDefinition.ts * Update dashboardDefinition.ts * Update src/pages/logosValidator/dashboardDefinition.ts Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> * Update dashboardDefinition.ts * Update dashboardDefinition.ts * Update dashboardDefinition.ts * Update dashboardDefinition.ts * Update dashboardDefinition.ts * Update dashboardDefinition.ts Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gabriel Ben Zenou <gabriel.benzenou@student-cs.fr> Co-authored-by: alexandre <alex.fauquette@gmail.com>
Fix #396 by allowing to pass parameter code in the URL
hunger.openfoodfacts.org/packaging?code=3245414079106
Also adding
country
andcreator
parameters