Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

change x to x_osgb, similar for y #558

Merged
merged 1 commit into from
Dec 20, 2021
Merged

change x to x_osgb, similar for y #558

merged 1 commit into from
Dec 20, 2021

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 20, 2021

Pull Request

Description

NO NEW CODE
change x to x_osgb and y to y_osgb

Fixes #543

How Has This Been Tested?

unittests

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Dec 20, 2021
@peterdudfield peterdudfield added this to the v17 dataset milestone Dec 20, 2021
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe just add an issue to remove the renaming? We probably want to upstream that change to nwp and Satip when creating the inputs.

@peterdudfield
Copy link
Contributor Author

peterdudfield commented Dec 20, 2021

Looks good! Maybe just add an issue to remove the renaming? We probably want to upstream that change to nwp and Satip when creating the inputs.

thanks

  1. Rename x --> x_osgb nwp#9
  2. rename x --> x_osgb Satip#42

and #560

@peterdudfield peterdudfield merged commit 4d36c39 into main Dec 20, 2021
@peterdudfield peterdudfield deleted the issue/543-x-y-osgb branch December 20, 2021 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Standardise x_coords naming in the NetCDF files
2 participants