Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Standardise x_coords naming in the NetCDF files #543

Closed
JackKelly opened this issue Dec 14, 2021 · 3 comments · Fixed by #558
Closed

Standardise x_coords naming in the NetCDF files #543

JackKelly opened this issue Dec 14, 2021 · 3 comments · Fixed by #558
Assignees
@peterdudfield
Labels
enhancement New feature or request
Milestone
v17 dataset

Comments

@JackKelly
Copy link
Member

Detailed Description

In gsp and pv NetCDF files, the x and y coords live in DataArrays called x_coords and y_coords.

In other data sources, the x and y coords live in DataArrays called x and y.

We should standardise 🙂

I don't mind which. Maybe x_coords and y_coords is more explicit, and so slightly better/
@JackKelly JackKelly added the enhancement New feature or request label Dec 14, 2021
@JackKelly JackKelly moved this to Todo in NIA: WP2 Dec 14, 2021
@peterdudfield
Copy link
Contributor

I think we should use #319

@peterdudfield
Copy link
Contributor

so perhaps from #319 should be
x_osgb
y_osgb

@JackKelly
Copy link
Member Author

SGTM!

@peterdudfield peterdudfield added this to the v17 dataset milestone Dec 17, 2021
@peterdudfield peterdudfield self-assigned this Dec 20, 2021
@peterdudfield peterdudfield mentioned this issue Dec 20, 2021
Merged
7 tasks
Repository owner moved this from Todo to Done in NIA: WP2 Dec 20, 2021
@kasiaocf kasiaocf removed this from NIA: WP2 Jan 20, 2022
@kasiaocf kasiaocf moved this to Todo in Nowcasting Jan 20, 2022
@kasiaocf kasiaocf moved this from Todo to Done in Nowcasting Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterdudfield peterdudfield

Labels
enhancement New feature or request
Projects
No open projects
Nowcasting
Status: Done
Milestone
v17 dataset
Development

Successfully merging a pull request may close this issue.

change x to x_osgb, similar for y openclimatefix/nowcasting_dataset
2 participants
@JackKelly @peterdudfield