chore(eslint): no-console error rule

eslint.config.js

@@ -26,6 +26,7 @@ module.exports = {
           "leadingUnderscore": "require"
         }
     ],
+    "no-console": "error",
     "no-shadow": "off",
     "@typescript-eslint/no-shadow": ["warn"],
     "@typescript-eslint/no-unused-vars": ["error", {"argsIgnorePattern": "^_", "args": "after-used"}],

packages/opentelemetry-metrics/src/export/ConsoleMetricExporter.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { diag } from '@opentelemetry/api';
 import { MetricExporter, MetricRecord, Histogram } from './types';
 import { ExportResult, ExportResultCode } from '@opentelemetry/core';
 
@@ -27,18 +28,18 @@ export class ConsoleMetricExporter implements MetricExporter {
     resultCallback: (result: ExportResult) => void
   ): void {
     for (const metric of metrics) {
-      console.log(metric.descriptor);
-      console.log(metric.labels);
+      diag.info('Descriptor', metric.descriptor);
+      diag.info('Labels', metric.labels);
       const point = metric.aggregator.toPoint();
       if (typeof point.value === 'number') {
-        console.log('value: ' + point.value);
+        diag.info('value: ', point.value);
       } else if (typeof (point.value as Histogram).buckets === 'object') {
         const histogram = point.value as Histogram;
-        console.log(
+        diag.info(
           `count: ${histogram.count}, sum: ${histogram.sum}, buckets: ${histogram.buckets}`
         );
       } else {
-        console.log(point.value);
+        diag.info('value: ', point.value);
       }
     }
     return resultCallback({ code: ExportResultCode.SUCCESS });

packages/opentelemetry-metrics/test/Meter.test.ts

@@ -804,7 +804,7 @@ describe('Meter', () => {
       let counter = 0;
 
       function getValue() {
-        console.log('getting value, counter:', counter);
+        diag.info('getting value, counter:', counter);
         if (++counter % 2 === 0) {
           return 3;
         }

packages/opentelemetry-metrics/test/export/ConsoleMetricExporter.test.ts

@@ -14,28 +14,29 @@
  * limitations under the License.
  */
 
+import { diag } from '@opentelemetry/api';
 import * as assert from 'assert';
 import * as sinon from 'sinon';
 import { ConsoleMetricExporter, MeterProvider, MetricKind } from '../../src';
 import { ValueType } from '@opentelemetry/api-metrics';
 
 describe('ConsoleMetricExporter', () => {
   let consoleExporter: ConsoleMetricExporter;
-  let previousConsoleLog: any;
+  let previousInfo: any;
 
   beforeEach(() => {
-    previousConsoleLog = console.log;
-    console.log = () => {};
+    previousInfo = diag.info;
+    diag.info = () => {};
     consoleExporter = new ConsoleMetricExporter();
   });
 
   afterEach(() => {
-    console.log = previousConsoleLog;
+    diag.info = previousInfo;
   });
 
   describe('.export()', () => {
     it('should export information about metrics', async () => {
-      const spyConsole = sinon.spy(console, 'log');
+      const spyInfo = sinon.spy(diag, 'info');
 
       const meter = new MeterProvider().getMeter(
         'test-console-metric-exporter'
@@ -51,24 +52,20 @@ describe('ConsoleMetricExporter', () => {
 
       await meter.collect();
       consoleExporter.export(meter.getProcessor().checkPointSet(), () => {});
-      assert.strictEqual(spyConsole.args.length, 3);
-      const [descriptor, labels, value] = spyConsole.args;
-      assert.deepStrictEqual(descriptor, [
-        {
-          description: 'a test description',
-          metricKind: MetricKind.COUNTER,
-          name: 'counter',
-          unit: '1',
-          valueType: ValueType.DOUBLE,
-        },
-      ]);
-      assert.deepStrictEqual(labels, [
-        {
-          key1: 'labelValue1',
-          key2: 'labelValue2',
-        },
-      ]);
-      assert.deepStrictEqual(value[0], 'value: 10');
+      assert.strictEqual(spyInfo.args.length, 3);
+      const [descriptor, labels, value] = spyInfo.args;
+      assert.deepStrictEqual(descriptor[1], {
+        description: 'a test description',
+        metricKind: MetricKind.COUNTER,
+        name: 'counter',
+        unit: '1',
+        valueType: ValueType.DOUBLE,
+      });
+      assert.deepStrictEqual(labels[1], {
+        key1: 'labelValue1',
+        key2: 'labelValue2',
+      });
+      assert.deepStrictEqual(value[1], 10);
     });
   });
 });

packages/opentelemetry-tracing/src/export/ConsoleSpanExporter.ts

@@ -14,6 +14,13 @@
  * limitations under the License.
  */
 
+import {
+  diag,
+  SpanAttributes,
+  SpanKind,
+  SpanStatus,
+  TimedEvent,
+} from '@opentelemetry/api';
 import { SpanExporter } from './SpanExporter';
 import { ReadableSpan } from './ReadableSpan';
 import {
@@ -51,7 +58,7 @@ export class ConsoleSpanExporter implements SpanExporter {
    * converts span info into more readable format
    * @param span
    */
-  private _exportInfo(span: ReadableSpan) {
+  private _exportInfo(span: ReadableSpan): LoggedSpan {
     return {
       traceId: span.spanContext.traceId,
       parentId: span.parentSpanId,
@@ -76,10 +83,23 @@ export class ConsoleSpanExporter implements SpanExporter {
     done?: (result: ExportResult) => void
   ): void {
     for (const span of spans) {
-      console.log(this._exportInfo(span));
+      diag.info('span', this._exportInfo(span));
     }
     if (done) {
       return done({ code: ExportResultCode.SUCCESS });
     }
   }
 }
+
+export interface LoggedSpan {
+  traceId: string;
+  parentId: string | undefined;
+  name: string;
+  id: string;
+  kind: SpanKind;
+  timestamp: number;
+  duration: number;
+  attributes: SpanAttributes;
+  status: SpanStatus;
+  events: TimedEvent[];
+}

packages/opentelemetry-tracing/test/export/BatchSpanProcessor.test.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { diag } from '@opentelemetry/api';
 import {
   AlwaysOnSampler,
   ExportResultCode,
@@ -237,7 +238,10 @@ describe('BatchSpanProcessor', () => {
             clock.tick(defaultBufferConfig.scheduledDelayMillis + 10);
             clock.restore();
 
-            console.log(exporter.getFinishedSpans().length);
+            diag.info(
+              'finished spans count',
+              exporter.getFinishedSpans().length
+            );
             assert.strictEqual(
               exporter.getFinishedSpans().length,
               totalSpans + 1

packages/opentelemetry-tracing/test/export/ConsoleSpanExporter.test.ts

@@ -14,26 +14,28 @@
  * limitations under the License.
  */
 
+import { diag } from '@opentelemetry/api';
 import * as assert from 'assert';
 import * as sinon from 'sinon';
 import {
   BasicTracerProvider,
   ConsoleSpanExporter,
+  LoggedSpan,
   SimpleSpanProcessor,
 } from '../../src';
 
 describe('ConsoleSpanExporter', () => {
   let consoleExporter: ConsoleSpanExporter;
-  let previousConsoleLog: any;
+  let previousInfo: any;
 
   beforeEach(() => {
-    previousConsoleLog = console.log;
-    console.log = () => {};
+    previousInfo = diag.info;
+    diag.info = () => {};
     consoleExporter = new ConsoleSpanExporter();
   });
 
   afterEach(() => {
-    console.log = previousConsoleLog;
+    diag.info = previousInfo;
   });
 
   describe('.export()', () => {
@@ -42,7 +44,7 @@ describe('ConsoleSpanExporter', () => {
         const basicTracerProvider = new BasicTracerProvider();
         consoleExporter = new ConsoleSpanExporter();
 
-        const spyConsole = sinon.spy(console, 'log');
+        const spyInfo = sinon.spy(diag, 'info');
         const spyExport = sinon.spy(consoleExporter, 'export');
 
         basicTracerProvider.addSpanProcessor(
@@ -56,9 +58,9 @@ describe('ConsoleSpanExporter', () => {
         const spans = spyExport.args[0];
         const firstSpan = spans[0][0];
         const firstEvent = firstSpan.events[0];
-        const consoleArgs = spyConsole.args[0];
-        const consoleSpan = consoleArgs[0];
-        const keys = Object.keys(consoleSpan).sort().join(',');
+        const infoArgs = spyInfo.args[0];
+        const loggedSpan = infoArgs[1] as LoggedSpan;
+        const keys = Object.keys(loggedSpan).sort().join(',');
 
         const expectedKeys = [
           'attributes',
@@ -75,7 +77,7 @@ describe('ConsoleSpanExporter', () => {
 
         assert.ok(firstSpan.name === 'foo');
         assert.ok(firstEvent.name === 'foobar');
-        assert.ok(consoleSpan.id === firstSpan.spanContext.spanId);
+        assert.ok(loggedSpan.id === firstSpan.spanContext.spanId);
         assert.ok(keys === expectedKeys);
 
         assert.ok(spyExport.calledOnce);

packages/opentelemetry-web/src/WebTracerProvider.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { diag } from '@opentelemetry/api';
 import {
   BasicTracerProvider,
   SDKRegistrationConfig,
@@ -41,7 +42,7 @@ export class WebTracerProvider extends BasicTracerProvider {
    */
   constructor(config: WebTracerConfig = {}) {
     if (typeof config.plugins !== 'undefined') {
-      console.warn(
+      diag.warn(
         'plugins option was removed, please use' +
           ' "registerInstrumentations" to load plugins'
       );

packages/opentelemetry-web/test/WebTracerProvider.test.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { diag } from '@opentelemetry/api';
 import { context, getSpan, setSpan, ContextManager } from '@opentelemetry/api';
 import { ZoneContextManager } from '@opentelemetry/context-zone';
 import { B3Propagator } from '@opentelemetry/propagator-b3';
@@ -49,7 +50,7 @@ describe('WebTracerProvider', () => {
 
     it('should show warning when plugins are defined', () => {
       const dummyPlugin1 = {};
-      const spyWarn = sinon.spy(window.console, 'warn');
+      const spyWarn = sinon.spy(diag, 'warn');
 
       const plugins = [dummyPlugin1];