-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): no-console error rule #2018
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2018 +/- ##
=======================================
Coverage 92.97% 92.98%
=======================================
Files 152 152
Lines 5925 5926 +1
Branches 1245 1245
=======================================
+ Hits 5509 5510 +1
Misses 416 416
|
I think the console exporters should actually export to console. |
I had the same dilemma. How about we add the following in the constructor of console exporters?
|
This will redirect all logs not just the exports. I would disable the rule for the few places in the exporter where |
packages/opentelemetry-metrics/src/export/ConsoleMetricExporter.ts
Outdated
Show resolved
Hide resolved
@vmarchaud @Flarna @legendecas Can you please merge the PR, since I don't have the write access to the repository? |
@skjindal93 Two maintainer approvals are required in this repo but there is only one till now. |
@skjindal93 did you sign the CLA ? |
Close and reopen to retrigger CLA |
Which problem is this PR solving?
Adds ESLint rule for avoiding any console log statements in the codebase
Fixes #2007 and #1861