Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/workflowgroups #41

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Feature/workflowgroups #41

merged 7 commits into from
Jul 18, 2023

Conversation

RaphaelNagato
Copy link
Contributor

What this PR solves

Description

  • Created WorkflowGroupDto class to get the request body for creating a new Workflow Group
  • Created WorkflowGroupResponsePayloadDto.cs for the JSON "data" payload received on creating a new Workflow Group.
  • Created WorkflowGroupBulkResponseDto.cs and WorkflowGroupSingleResponseDto.cs for the JSON response payloads to "Create a Workflow Group" and "Get all Workflow Groups".
  • Updated INovuClient with IWorkflowClient
  • Updated README.md to include WorkflowGroup client

Tests

  • Added Tests but unable to check due to the absence of Novu's API key.

@unicodeveloper unicodeveloper requested a review from wh1337 July 17, 2023 07:44
@wh1337
Copy link
Collaborator

wh1337 commented Jul 18, 2023

Reviewing the PR now

@wh1337 wh1337 merged commit 690cf72 into novuhq:main Jul 18, 2023
@wh1337 wh1337 mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wh1337 wh1337 wh1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: WorkflowGroupClient
2 participants
@RaphaelNagato @wh1337