Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to remove the dependency on a real connection to api.novu.co #34

Closed
wh1337 opened this issue Jun 2, 2023 · 5 comments
Closed

Update tests to remove the dependency on a real connection to api.novu.co #34

wh1337 opened this issue Jun 2, 2023 · 5 comments
Assignees
@wh1337 @RaphaelNagato
Labels
chore Things that just need to be done

Comments

@wh1337
Copy link
Collaborator

wh1337 commented Jun 2, 2023

Currently, when the test run they require a real connection to the api.novu.co. We need to refactor this to use a mock api so that tests from external PRs can run. This also follows the normal testing process.
@wh1337 wh1337 added the good first issue Good for newcomers label Jun 2, 2023
@wh1337 wh1337 added chore Things that just need to be done and removed good first issue Good for newcomers labels Jul 10, 2023
@wh1337 wh1337 self-assigned this Jul 10, 2023
@RaphaelNagato
Copy link
Contributor

Hi @wh1337, I will like to pick this up once my PR to add the WorkflowClient is resolved. Thanks

@wh1337
Copy link
Collaborator Author

wh1337 commented Jul 18, 2023

@RaphaelNagato I have merged PR #41 (Thank you by the way!) Feel free to start working on this when you can.

Thanks!

@RaphaelNagato
Copy link
Contributor

Hi @wh1337 , I plan to use Wiremock.Net library to resolve this issue, is it okay by you?

@wh1337
Copy link
Collaborator Author

wh1337 commented Jul 19, 2023

@RaphaelNagato I'm good with that

toddb pushed a commit to picmi/novu-dotnet that referenced this issue Aug 15, 2023
feat: upgrade of the client library
d196db0 
 - novuhq#34 - injectable
 - novuhq#45
 - added DI for client for tests and extensions for production applications
 - reworked the tests between integration and micro tests
 - added workflows (and steps) can now be added reasonably stably
 - upgraded client to allow for either HttpClient or RestService
@toddb toddb mentioned this issue Aug 15, 2023
Merged
wh1337 pushed a commit that referenced this issue Aug 25, 2023
@wh1337
feat: upgrade of the client library
60f9498 
 - #34 - injectable
 - #45
 - added DI for client for tests and extensions for production applications
 - reworked the tests between integration and micro tests
 - added workflows (and steps) can now be added reasonably stably
 - upgraded client to allow for either HttpClient or RestService
@toddb
Copy link
Collaborator

toddb commented Aug 27, 2023

Released as part of 0.3.0. However, please note that the additional code to help streamline wiring up the configuration exists in Novu.Extensions.

See #55 for discussion and this code should be release soon.

@wh1337 wh1337 closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wh1337 wh1337

@RaphaelNagato RaphaelNagato

Labels
chore Things that just need to be done
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

chore/test-update novuhq/novu-dotnet
3 participants
@toddb @wh1337 @RaphaelNagato