Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventTriggerDataDto JSON data contract needs plural 'overrides' #45

Closed
1 of 5 tasks
toddb opened this issue Aug 4, 2023 · 1 comment
Closed
1 of 5 tasks

EventTriggerDataDto JSON data contract needs plural 'overrides' #45

toddb opened this issue Aug 4, 2023 · 1 comment

Comments

@toddb
Copy link
Collaborator

toddb commented Aug 4, 2023

  • I'm submitting a...

    • typo
    • bug report
    • feature request
    • question about the decisions made in the repository
    • question about how to use this project

  • Summary
    The JSON interface should be plural overrides (rather than the singular).

novu-dotnet/src/Novu/DTO/EventTriggerDataDto.cs

Line 21 in 0776c82

[JsonProperty("override")] public List<object>? Overrides { get; set; }

  • Other information

see https://docs.novu.co/api/trigger-event/
toddb pushed a commit to picmi/novu-dotnet that referenced this issue Aug 15, 2023
feat: upgrade of the client library
d196db0 
 - novuhq#34 - injectable
 - novuhq#45
 - added DI for client for tests and extensions for production applications
 - reworked the tests between integration and micro tests
 - added workflows (and steps) can now be added reasonably stably
 - upgraded client to allow for either HttpClient or RestService
@toddb toddb mentioned this issue Aug 15, 2023
Merged
wh1337 pushed a commit that referenced this issue Aug 25, 2023
@wh1337
feat: upgrade of the client library
60f9498 
 - #34 - injectable
 - #45
 - added DI for client for tests and extensions for production applications
 - reworked the tests between integration and micro tests
 - added workflows (and steps) can now be added reasonably stably
 - upgraded client to allow for either HttpClient or RestService
@toddb
Copy link
Collaborator Author

toddb commented Aug 27, 2023

Released as part of 0.3.0

@toddb toddb closed this as completed Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toddb