-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add avatar to sharing dropdown #373
add avatar to sharing dropdown #373
Conversation
@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @raghunayyar, @tcitworld and @jancborchardt to be potential reviewers. |
The avatars should be added to the sharing list as well, but I'm generally not too happy about the current design of the "shared-with" list. cc @jancborchardt @eppfel @nextcloud/designers |
cc @nickvergessen who reported the original avatar issue |
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
6cbcb23
to
a54c491
Compare
Maybe the whole area could have the calendar color instead of just the dot ? |
Yeah well I can't think of any other part of Nextcloud where the sidebar has to be reduced this small to show the calendar aside, so whatever we choose, I guess it wouldn't be just like the files app. :( |
I created an issue about the "shared-with" list: #377 |
@tcitworld What browser / os is that? :) |
Firefox 52 on gnu/linux. Chrome/ium doesn't have this issue. |
Seems to be a resolution issue. If I use the adaptive view of Firefox to change the resolution (including the one I actually use, 1920x1080), the issue is gone. |
By the way, see how the share dropdown is nice and white in the files sidebar – can you take the same styles from there? :) |
fixes #207