Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add avatar to sharing list #207

Closed
nickvergessen opened this issue Nov 29, 2016 · 7 comments · Fixed by #373
Closed

Add avatar to sharing list #207

nickvergessen opened this issue Nov 29, 2016 · 7 comments · Fixed by #373
Assignees
@georgehrke
Labels
2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone
1.5.4-current-mai...

Comments

@nickvergessen
Copy link
Member

Currently the search dropdown and the list of shares don't use the displayname and the avatar. Instead it only shows the id (ugly on ldap). Both should be fixed.
@nickvergessen nickvergessen added design Related to design, interface, interaction design, UX, etc. enhancement-proposed labels Nov 29, 2016
@georgehrke
Copy link
Member

The display name thing should be fixed with 1.4.1, can you validate that?

@georgehrke
Copy link
Member

Is there a proper API or set of css classes and templates in the server to add the avatar?
cc @jancborchardt

@nickvergessen
Copy link
Member Author

/~https://github.com/nextcloud/spreed/blob/master/js/app.js#L104 +
/~https://github.com/nextcloud/spreed/blob/master/js/app.js#L120-L124

@georgehrke
Copy link
Member

regarding the label:
This was fixed here: 927f412#diff-3f31cf29dabccac17dc76bf33ba73634

@georgehrke georgehrke changed the title Sharing list avatars and displaynames Add avatar to sharing list Nov 29, 2016
@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of enhancement New feature request good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed enhancement-proposed labels Nov 29, 2016
@georgehrke georgehrke added this to the 1.6.0-next milestone Nov 29, 2016
@nickvergessen
Copy link
Member Author

Ah I pulled master, but didn't rebuild JS stuff, works now.

@nickvergessen
Copy link
Member Author

Also I just noticed, when adding a sharee, the uid is displayed until a page refresh is done, so you seem have to missed one spot.

@georgehrke
Copy link
Member

Indeed /~https://github.com/nextcloud/calendar/blob/master/js/app/service/calendarService.js#L541L553

apparently forgot to fix that one

@georgehrke georgehrke self-assigned this Mar 18, 2017
@georgehrke georgehrke mentioned this issue Mar 20, 2017
Merged
@georgehrke georgehrke added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgehrke georgehrke

Labels
2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
1.5.4-current-maintenance
Development

Successfully merging a pull request may close this issue.

add avatar to sharing dropdown nextcloud/calendar
2 participants
@nickvergessen @georgehrke