[infra] Reintroduce the cherry pick workflow #15293
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Create cherry-pick PR | ||
| on: | ||
| pull_request_target: | ||
| branches: | ||
| - 'v*.x' | ||
| - 'master' | ||
| types: ['closed'] | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| create_pr: | ||
| name: Create cherry-pick PR | ||
| uses: mui/mui-public/.github/workflows/prs_create-cherry-pick-pr.yml@master | ||
| permissions: | ||
| contents: write | ||
| issues: write | ||
|
There was a problem hiding this comment. |
||
| pull-requests: write | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michelengelen Do you think we can make cherry-pick possible after the PR was merged, but didn't have the "needs cherry-pick" label?
Take this PR for example: #15255 It was merged, and then we realized we want to cherry-pick it to v7. Since it's already merged, adding the "needs cherry-pick" label is too late.
Ideally, we would have 2 triggers for cherry-pick:
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great idea. 👍
It might prove slightly tricky to use because we would probably need to ensure the proper
vX.xlabels are added before adding theneeds cherry-picklabel. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already on my list! But good observation! 💪🏻👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative is to have a manual
workflow_dispatch, with a requiredPR # to cherrypickandtarget