[infra] Reintroduce the cherry pick workflow #15293
Conversation
michelengelen
added
the
scope: infra
|
Deploy preview: https://deploy-preview-15293--material-ui-x.netlify.app/ |
| branches: | ||
| - 'v*.x' | ||
| - 'master' | ||
| types: ['closed'] |
There was a problem hiding this comment.
@michelengelen Do you think we can make cherry-pick possible after the PR was merged, but didn't have the "needs cherry-pick" label?
Take this PR for example: #15255 It was merged, and then we realized we want to cherry-pick it to v7. Since it's already merged, adding the "needs cherry-pick" label is too late.
Ideally, we would have 2 triggers for cherry-pick:
- PR is merged and has the "needs cherry-pick" label
- Label is added to the PR, the PR now has the "needs cherry-pick" label, and it's already merged.
What do you think?
There was a problem hiding this comment.
That's a great idea. 👍
It might prove slightly tricky to use because we would probably need to ensure the proper vX.x labels are added before adding the needs cherry-pick label. 🤔
There was a problem hiding this comment.
It's already on my list! But good observation! 💪🏻👍🏼
There was a problem hiding this comment.
An alternative is to have a manual workflow_dispatch, with a required PR # to cherrypick and target
| uses: mui/mui-public/.github/workflows/prs_create-cherry-pick-pr.yml@master | ||
| permissions: | ||
| contents: write | ||
| issues: write |
There was a problem hiding this comment.
added a change that should fix the workflow