Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#2665] Fix phone-parsing Safari (iOS only) #1369

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

🐛 [#2665] Fix phone-parsing Safari (iOS only) #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/open_inwoner/conf/parts/case_document_notification.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ <h1>Nieuw:</h1>
<h2>{{ type_description }}</h2>
</td>
<td class="td--responsive td-mail td-mail__bg-info td__padding-all td__rightcell td__alignright" colspan="3">
<p><span class="text-color__small-gray-900">Zaaknummer: </span><br/>{{ identification }}</p>
<p><span class="text-color__small-gray-900 phone-parsing">Zaaknummer: </span><br/>&zwj;{{ identification }}</p>
</td>
</tr>

Expand Down
2 changes: 1 addition & 1 deletion src/open_inwoner/conf/parts/case_status_notification.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ <h1>Nieuw:</h1>
<h2>{{ type_description }}</h2>
</td>
<td class="td--responsive td-mail td-mail__bg-info td__padding-all td__rightcell td__alignright" colspan="3">
<p><span class="text-color__small-gray-900">Zaaknummer: </span><br/>{{ identification }}</p>
<p><span class="text-color__small-gray-900 phone-parsing">Zaaknummer: </span><br/>&zwj;{{ identification }}</p>
</td>
</tr>

Expand Down
2 changes: 1 addition & 1 deletion src/open_inwoner/conf/parts/case_status_notification_action_required.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ <h1>Nieuw:</h1>
<h2>{{ type_description }}</h2>
</td>
<td class="td--responsive td-mail td-mail__bg-danger td__padding-all td__rightcell td__alignright" colspan="3">
<p><span class="text-color__small-gray-900">Zaaknummer: </span><br/>{{ identification }}</p>
<p><span class="text-color__small-gray-900 phone-parsing">Zaaknummer: </span><br/>&zwj;{{ identification }}</p>
</td>
</tr>

Expand Down
11 changes: 0 additions & 11 deletions src/open_inwoner/scss/components/AccessibilityHeader/AccessibilityHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,6 @@
line-height: var(--font-line-height-body-medium);
}
}

.skip-link {
position: absolute;
top: -50px;
transition: top 0.2s;

&:focus {
position: relative;
top: 0;
}
}
}

// Accessibility header within different components
Expand Down
3 changes: 3 additions & 0 deletions src/open_inwoner/scss/components/AccessibilitySkipLink/AccessibilitySkipLink.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
text-decoration: none;

&--visible-on-focus {
left: 100%;

&:focus {
left: initial;
text-decoration: none;
}
}
Expand Down
10 changes: 10 additions & 0 deletions src/open_inwoner/scss/views/_view.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,14 @@
display: inline;
}
}

// Remove Safari iOS phone-parsing from specific elements
.phone-parsing {
pointer-events: none;
}
// Hide style for iOS-rendered anchor element
.phone-parsing > a {
text-decoration: none;
color: inherit;
}
}
11 changes: 11 additions & 0 deletions src/open_inwoner/static/mailcss/email.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,17 @@ strong .color--primary, strong .color--secondary {
border-top: 3px solid #999999;
}

/* iOS specific */

.phone-parsing {
pointer-events: none;
}

.phone-parsing > a {
text-decoration: none;
color: inherit;
}

/* CKEditor only */

.cke_editable a {
Expand Down
5 changes: 4 additions & 1 deletion src/open_inwoner/templates/pages/cases/list_inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ <h2 class="card__heading-2">{{ case.description }}</h2>
{% else %}
{% list_item case.current_status caption=_("Status") compact=True strong=False %}
{% endif %}
{% list_item case.identification caption=_("Zaaknummer") compact=True strong=False %}
<li class="list-item list-item--compact">
<p class="utrecht-paragraph list-item__caption">Zaaknummer</p>
<p class="utrecht-paragraph phone-parsing">&zwj;{{ case.identification }}</p>
</li>
{% endrender_list %}

<span class="link link--icon link--secondary">
Expand Down
Loading