Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#2665] Fix phone-parsing Safari (iOS only) #1369

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Aug 22, 2024

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2665

The turn-numbers-into-phone-links feature should be disabled with the format-detection meta-tag, but... on every Safari and iOS update this breaks again 😡; many users on new devices report the meta tag does not solve the problem, so we need to create a hack with pointer-events is zero and add a zero-width joiner ‍ to make the numbers unrecognizable.
I've also added these to the Zaaknummers e-mail templates, since those are also parsed in iOS.

While I was reproducing all this in Browserstack I found a bug in the skip-link in Safari which is also solved here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (65b1058) to head (d761b2e).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1369      +/-   ##
===========================================
- Coverage    94.23%   94.23%   -0.01%     
===========================================
  Files         1068     1070       +2     
  Lines        39348    39412      +64     
===========================================
+ Hits         37080    37140      +60     
- Misses        2268     2272       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the fix/2665-safari-format branch from b7c6a77 to 0a866a3 Compare January 14, 2025 09:23
@jiromaykin jiromaykin changed the title 🐛 [#2665] Fix phone-parsing safari 🐛 [#2665] Fix phone-parsing Safari (iOS only) Jan 20, 2025
@jiromaykin jiromaykin force-pushed the fix/2665-safari-format branch from 0756b0d to d761b2e Compare January 20, 2025 13:08
@jiromaykin jiromaykin marked this pull request as ready for review January 20, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants