Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS build and use iOS 18.1 simulators on Xcode 16.2 #1122

Closed
wants to merge 2 commits into from
Closed

Fix iOS build and use iOS 18.1 simulators on Xcode 16.2 #1122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d5eab9
Fix iOS build SDK for Xcode 16.2
BPerlakiH Feb 22, 2025
1271576
Show destinations
BPerlakiH Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/actions/xcbuild/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ runs:
# /~https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode
run: sudo xcode-select -s /Applications/Xcode_15.2.0.app

- name: Use specific iOS SDK
env:
DEST: ${{ inputs.xc-destination }}
IOS_SDK: "18.1"
shell: bash
run: |
if [[ "$DEST" =~ "iOS" ]]; then
echo "XC_DEST_OS=;OS=$IOS_SDK" >> $GITHUB_ENV
else
echo "XC_DEST_OS=" >> $GITHUB_ENV
fi

- name: Create Keychain
shell: bash
env:
Expand Down Expand Up @@ -104,14 +116,18 @@ runs:
shell: bash
run: xcrun xcodebuild -workspace $XC_WORKSPACE -scheme $XC_SCHEME -showBuildSettings

- name: Show eligible build destinations for the ${{ inputs.XC_SCHEME }}
shell: bash
run: xcrun xcodebuild -showdestinations -scheme ${{ inputs.XC_SCHEME }}

- name: Build with Xcode
env:
ACTION: ${{ inputs.action }}
VERSION: ${{ inputs.version }}
XC_WORKSPACE: ${{ inputs.XC_WORKSPACE }}
XC_SCHEME: ${{ inputs.XC_SCHEME }}
XC_CONFIG: ${{ inputs.XC_CONFIG }}
XC_DESTINATION: ${{ inputs.xc-destination }}
XC_DESTINATION: ${{ inputs.xc-destination }}${{ env.XC_DEST_OS }}
EXTRA_XCODEBUILD: ${{ inputs.EXTRA_XCODEBUILD }}
shell: bash
run: xcrun xcodebuild ${EXTRA_XCODEBUILD} -workspace $XC_WORKSPACE -scheme $XC_SCHEME -destination "$XC_DESTINATION" -configuration $XC_CONFIG -onlyUsePackageVersionsFromResolvedFile -allowProvisioningUpdates -verbose -archivePath $PWD/Kiwix-$VERSION.xcarchive ${ACTION}