Fix iOS build and use iOS 18.1 simulators on Xcode 16.2 #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 34.69% 34.73% +0.03%
==========================================
Files 137 137
Lines 7859 7859
==========================================
+ Hits 2727 2730 +3
+ Misses 5132 5129 -3 ☔ View full report in Codecov by Sentry. |
BPerlakiH
force-pushed
the
fix-iOS-build-SDK
branch
from
7168386 to
1271576
Compare
|
This is not completely ready for Xcode 16, closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former PR updating to Xcode 16.2, made the build fail.
Reason being is that the default iOS SDK for simulators in Xcode 16.2 is the "latest", which is currently iOS 18.2. The issue is that Github runners (macOS-14) do not have that pre-installed yet, so we need to fall back to simulators running iOS 18.1, which is installed:
/~https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md
well it's still not ok, maybe it's because non of the simulators are pre-installed as per Apple:
https://developer.apple.com/documentation/xcode-release-notes/xcode-16-release-notes
I am not convinced at this point to do this update, if we need to download the simulator environment for every single build we run on GitHub Actions ...