Support prefixes with args #48
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 Continue to review full report at Codecov.
|
|
Doesn't seem quite right yet IanButterworth/Example.jl#1 |
|
ok, this is working over in IanButterworth/Example.jl#1 with both single prefixes and prefixes with arguments Is use of cc. @giordano |
|
Bumping this so that julia-actions/julia-buildpkg#16 can eventually get merged. |
|
@SaschaMann 🙏🏻 |
| @@ -51,12 +51,16 @@ runs: | |||
| JULIA_PKG_SERVER: "" | |||
| - run: | | |||
| # The Julia command that will be executed | |||
| julia_cmd=( julia --color=yes --depwarn=${{ inputs.depwarn }} --inline=${{ inputs.inline }} --project=${{ inputs.project }} -e 'import Pkg;include(joinpath(ENV["GITHUB_ACTION_PATH"], "kwargs.jl"));kwargs = Kwargs.kwargs(;coverage = :(${{ inputs.coverage }}),force_latest_compatible_version = :(${{ inputs.force_latest_compatible_version }}), julia_args = ["--check-bounds=${{ inputs.check_bounds }}"]);Pkg.test(; kwargs...)' ) | |||
| julia_cmd="julia --color=yes --depwarn=${{ inputs.depwarn }} --inline=${{ inputs.inline }} --project=${{ inputs.project }} -e 'import Pkg;include(joinpath(ENV[\"GITHUB_ACTION_PATH\"], \"kwargs.jl\"));kwargs = Kwargs.kwargs(;coverage = :(${{ inputs.coverage }}),force_latest_compatible_version = :(${{ inputs.force_latest_compatible_version }}), julia_args = [\"--check-bounds=${{ inputs.check_bounds }}\"]);Pkg.test(; kwargs...)'" | |||
There was a problem hiding this comment.
Sorry I forgot about this for so long.
My understanding of bash is that for commands like this, parantheses should be used. The if/then block below deals with the main issue we ran into before when using double quotes but there might be other unintentional consequences I'm not aware of. So I'd prefer to stick to the best practice that was recommended back then rather switching to double quotes.
The second suggestion in #41 seems like it should work without going back to double quotes.
|
May I carefully bump this PR? I could really use this feature in a range of package CIs. Seems like it's only a small change away from being mergeable. |
Supersedes #48 Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Supersedes #48 Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Implements @colinxs's suggestion in #41
Fixes #41