Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prefix option, to match julia-runtest #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IanButterworth
Copy link
Member

If xvfb-run etc. is needed to run tests, it likely will be needed at build time too, which is the case for CimGui.jl

@IanButterworth IanButterworth requested a review from a team as a code owner July 17, 2021 15:47
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #16 (b5b11bc) into master (f995fa4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f995fa4...b5b11bc. Read the comment docs.

@SaschaMann
Copy link
Member

Let's wait for julia-actions/julia-runtest#48 to be resolved so that both actions share the same logic.

@DilumAluthge DilumAluthge requested review from SaschaMann and removed request for a team July 18, 2021 08:31
@omus
Copy link
Contributor

omus commented Jan 9, 2024

Since julia-actions/julia-runtest#48 is closed should this PR also be closed?

@IanButterworth
Copy link
Member Author

That PR was replaced by julia-actions/julia-runtest#71 which has been merged.

I guess we still need to bring that over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants