Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ConstantBackoff: always return the same duration #12

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions policies/constant.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package policies

import "time"

func GetConstantPolicy(duration time.Duration) Policy {
return func(count int) time.Duration {
if count == 0 {
return 0
}

return duration
}
}
27 changes: 27 additions & 0 deletions policies/constant_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package policies_test

import (
"testing"
"time"

"github.com/stretchr/testify/assert"

"github.com/honestbank/backoff-policy/policies"
)

func TestGetConstantPolicy(t *testing.T) {
t.Run("returns correct duration based on count", func(t *testing.T) {
policy := policies.GetConstantPolicy(time.Millisecond * 100)
assert.Equal(t, time.Millisecond*0, policy(0))
assert.Equal(t, time.Millisecond*100, policy(1))
assert.Equal(t, time.Millisecond*100, policy(2))
assert.Equal(t, time.Millisecond*100, policy(3))
})
t.Run("value is capped at max count", func(t *testing.T) {
policy := policies.GetConstantPolicy(time.Millisecond * 100)
assert.Equal(t, policy(10), policy(10))
assert.Equal(t, policy(10), policy(11))
assert.Equal(t, policy(10), policy(12))
assert.Equal(t, policy(10), policy(13))
})
Comment on lines +20 to +26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this test

}