-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ConstantBackoff: always return the same duration #12
Open
rohits1101
wants to merge
9
commits into
main
Choose a base branch
from
feat/rohit/acq-2498/add-constant-backoff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
afa8028
test: fails on local, check what happens on ci
rohits1101 a479969
add ConstantBackoff: a wrapper around ExponentialPolicy
rohits1101 adf53d9
revert the test
rohits1101 a01f67a
update the constant policy, don't need the max
rohits1101 b649940
lint
rohits1101 9a76742
upgrade golang
rohits1101 ca70db4
fix ci stage title
rohits1101 d974ef1
fix build.yaml
rohits1101 07c6709
add shiftleft
rohits1101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package policies | ||
|
||
import "time" | ||
|
||
func GetConstantPolicy(duration time.Duration) Policy { | ||
return func(count int) time.Duration { | ||
if count == 0 { | ||
return 0 | ||
} | ||
|
||
return duration | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package policies_test | ||
|
||
import ( | ||
"testing" | ||
"time" | ||
|
||
"github.com/stretchr/testify/assert" | ||
|
||
"github.com/honestbank/backoff-policy/policies" | ||
) | ||
|
||
func TestGetConstantPolicy(t *testing.T) { | ||
t.Run("returns correct duration based on count", func(t *testing.T) { | ||
policy := policies.GetConstantPolicy(time.Millisecond * 100) | ||
assert.Equal(t, time.Millisecond*0, policy(0)) | ||
assert.Equal(t, time.Millisecond*100, policy(1)) | ||
assert.Equal(t, time.Millisecond*100, policy(2)) | ||
assert.Equal(t, time.Millisecond*100, policy(3)) | ||
}) | ||
t.Run("value is capped at max count", func(t *testing.T) { | ||
policy := policies.GetConstantPolicy(time.Millisecond * 100) | ||
assert.Equal(t, policy(10), policy(10)) | ||
assert.Equal(t, policy(10), policy(11)) | ||
assert.Equal(t, policy(10), policy(12)) | ||
assert.Equal(t, policy(10), policy(13)) | ||
}) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this test