feat: Add ConstantBackoff: always return the same duration #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not do exponential backoff, but rather retries with a constant time
cyberhck
approved these changes
Apr 4, 2023
policies/constant.go
Outdated
| import "time" | ||
|
|
||
| func GetConstantPolicy(duration time.Duration, max int) Policy { | ||
| return GetExponentialPolicy(1, duration, max) |
There was a problem hiding this comment.
if it's really a constant, what would the max do? why not just write the constant policy?
There was a problem hiding this comment.
let's just write the constant policy that backs off by duration time.
rohits1101
changed the title
cyberhck
previously approved these changes
Apr 4, 2023
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
maetolay
previously approved these changes
Apr 4, 2023
rohits1101
force-pushed
the
feat/rohit/acq-2498/add-constant-backoff
branch
from
a293070 to
d974ef1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kelu-diao
reviewed
Apr 4, 2023
Comment on lines
+20
to
+26
| t.Run("value is capped at max count", func(t *testing.T) { | ||
| policy := policies.GetConstantPolicy(time.Millisecond * 100) | ||
| assert.Equal(t, policy(10), policy(10)) | ||
| assert.Equal(t, policy(10), policy(11)) | ||
| assert.Equal(t, policy(10), policy(12)) | ||
| assert.Equal(t, policy(10), policy(13)) | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write ConstantBackoff which always returns the same duration, except for the first attempt which is always a zero
This change is