Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle milestone events for issues and PR #5947

Merged
merged 2 commits into from
Feb 3, 2019
Merged

handle milestone events for issues and PR #5947

merged 2 commits into from
Feb 3, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Feb 3, 2019

Fixes #5865

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 3, 2019
@techknowlogick
Copy link
Member

Looks good. Can you add them to the other hook types too?

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 3, 2019
@codecov-io
Copy link

codecov-io commented Feb 3, 2019 •
edited
Loading

Codecov Report

Merging #5947 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5947      +/-   ##
==========================================
- Coverage   38.54%   38.54%   -0.01%     
==========================================
  Files         330      330              
  Lines       48518    48526       +8     
==========================================
+ Hits        18700    18703       +3     
- Misses      27111    27117       +6     
+ Partials     2707     2706       -1
Impacted Files Coverage Δ
models/webhook_slack.go 0% <0%> (ø) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c0f7d...7268fcd. Read the comment docs.

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Feb 3, 2019
@adelowo
Copy link
Member Author

adelowo commented Feb 3, 2019 •
edited
Loading

@techknowlogick All other webhooks already support this

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 3, 2019
@techknowlogick
Copy link
Member

@adelowo thanks :)

@techknowlogick techknowlogick merged commit 746cf22 into go-gitea:master Feb 3, 2019
@adelowo adelowo deleted the fix_5865 branch February 3, 2019 18:32
@lunny
Copy link
Member

lunny commented Feb 4, 2019

@adelowo I think this should be back port to release/v1.7

adelowo added a commit to adelowo/gitea that referenced this pull request Feb 4, 2019
@adelowo
handle milestone events for issues and PR (go-gitea#5947)
ce8fcdd
@adelowo adelowo mentioned this pull request Feb 4, 2019
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 4, 2019
zeripath pushed a commit that referenced this pull request Feb 4, 2019
@adelowo @zeripath
handle milestone events for issues and PR (#5947) (#5955)
477b4de 
Backport of #5947
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Webhook empty text
7 participants
@adelowo @techknowlogick @codecov-io @lunny @zeripath @lafriks @GiteaBot