Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook empty text #5865

Closed
2 of 7 tasks
FriedrichVonSchnitzel opened this issue Jan 27, 2019 · 1 comment · Fixed by #5947
Closed
2 of 7 tasks

Webhook empty text #5865

FriedrichVonSchnitzel opened this issue Jan 27, 2019 · 1 comment · Fixed by #5947

Comments

@FriedrichVonSchnitzel
Copy link

FriedrichVonSchnitzel commented Jan 27, 2019

  • Gitea version (or commit ref): a757920
  • Git version:
  • Operating system: Debian (docker)
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
Request
Response
200
Headers
Request URL: https://hooks.slack.com/services/.../.../..........
Request method: POST
Content-Type: application/json
X-GitHub-Delivery: 4ebaceaf-ecfd-4522-8873-bdff299d4244
X-GitHub-Event: issues
X-Gitea-Delivery: 4ebaceaf-ecfd-4522-8873-bdff299d4244
X-Gitea-Event: issues
X-Gogs-Delivery: 4ebaceaf-ecfd-4522-8873-bdff299d4244
X-Gogs-Event: issues
Content
{
  "channel": "#channel",
  "text": "",
  "username": "Gitea",
  "icon_url": "http://domain.com:3000/img/gitea-sm.png",
  "unfurl_links": 0,
  "link_names": 0,
  "attachments": [
    {
      "fallback": "",
      "color": "",
      "title": "",
      "text": ""
    }
  ]
}

Description

Webhooks to slack contain empty texts when notifying about milestones assigned to issues.
The bug occurs regardless of what is selected in the webhook settings (Trigger on: All events / Custom Events... - all selected). Example Webhook request from "Recent deliveries" provided above.
...

Screenshots

untitled

@KubqoA
Copy link
Contributor

KubqoA commented Jan 27, 2019

It's probably due to the fact, that the slack webhook implementation for issues doesn't check for api.HookIssueMilestoned and api.HookIssueDemilestoned. Maybe I could write you a PR.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants