-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Porting Examples - Fluorescence #1424
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test examples on staging/rewrite
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #1424 +/- ##
=========================================
+ Coverage 84.9% 85.1% +0.2%
=========================================
Files 91 91
Lines 3744 3744
Branches 728 728
=========================================
+ Hits 3180 3189 +9
+ Misses 450 443 -7
+ Partials 114 112 -2 ☔ View full report in Codecov by Sentry. |
for less CI confusion
Reduce some CI clutter, benchmarks will have to be re-created in a more meaningful way anyways post the rewrite finish.
Only global and some basic comparisons, still WIP
ed1a59b
to
0e68c1b
Compare
README contains reference to publications describing an analysis of the data
|
Closing PR in favor of #1425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to staging/rewrite branch for examples
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Please provide enough information so that others can review your pull request:
Explain the details for making this change. What existing problem does the pull request solve?.
Change summary
Checklist
Closes issues
closes #XXXX