Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Porting Examples - Fluorescence #1424

Closed
wants to merge 10 commits into from

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Jan 28, 2024

Switch to staging/rewrite branch for examples

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?.

Change summary

  • Change1
  • Change2

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)
  • 👌 Closes issue (mandatory for ✨ feature and 🩹 bug fix PR's)
  • 🧪 Adds new tests for the feature (mandatory for ✨ feature and 🩹 bug fix PR's)
  • 📚 Adds documentation of the feature

Closes issues

closes #XXXX

Test examples on staging/rewrite
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch jsnel/pyglotaran/porting/ex_fluorescence

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (491a7b6) 84.9% compared to head (ddb30ae) 85.1%.

Additional details and impacted files
@@            Coverage Diff            @@
##           staging   #1424     +/-   ##
=========================================
+ Coverage     84.9%   85.1%   +0.2%     
=========================================
  Files           91      91             
  Lines         3744    3744             
  Branches       728     728             
=========================================
+ Hits          3180    3189      +9     
+ Misses         450     443      -7     
+ Partials       114     112      -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsnel and others added 8 commits January 28, 2024 19:03
@jsnel jsnel force-pushed the porting/ex_fluorescence branch from ed1a59b to 0e68c1b Compare January 28, 2024 19:49
README contains reference to publications describing an analysis of the data
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jsnel
Copy link
Member Author

jsnel commented Jan 29, 2024

Closing PR in favor of #1425

@jsnel jsnel closed this Jan 29, 2024
@jsnel jsnel deleted the porting/ex_fluorescence branch January 29, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants