Build in linux docker, test on supported platforms #563

vaind · 2022-02-15T12:40:44Z

Uses a linux+docker based Unity to prepare "build projects" for all platforms and then runs the actual build on the target platforms

#skip-changelog

.github/workflows/ci.yml

previously crashed with https://forum.unity.com/threads/how-to-run-target-platform-tests-in-docker.1163261/#post-7894762

vaind

Some info for a future reviewer

vaind · 2022-02-17T08:35:00Z

.github/workflows/ci.yml

-        with:
-          path: samples/artifacts/builds
-          # using hash of package.json to bust cache on release builds which modify it
-          key: samples/artifacts/builds|${{ matrix.os }}-${{ matrix.unity-version }}-${{ matrix.unity-version-changeset }}-${{ hashFiles('package/package.json') }}


This was caching the android (smoke-test) player build but that doesn't make sense (with the key based only on the package.json) - we actually weren't testing the code changes made in the PRs if the cache key hit...

vaind · 2022-02-17T08:36:09Z

.github/workflows/ci.yml

-          key: samples/unity-of-bugs/Library|${{ matrix.os }}-${{ matrix.unity-version }}-${{ matrix.unity-version-changeset }}-${{ hashFiles('samples/unity-of-bugs/Packages/packages-lock.json') }}
+          path: |
+            samples/unity-of-bugs/Library/Packages
+            temp/unity-packages/Library/ScriptAssemblies/*.TestRunner.*


TestRunner wasn't cached - caching it speeds up (skips) UnityRestorePackages target

vaind · 2022-02-17T08:36:47Z

.github/workflows/ci.yml

-      - name: Integration Test - Create new Project
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-create-project.ps1 "${{ env.UNITY_PATH }}"
-
-      - name: Integration Test - Build Standalone Player without Sentry SDK
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-build-project.ps1 "${{ env.UNITY_PATH }}"
-
-      - name: Integration Test - Add Sentry to test project
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-update-sentry.ps1 "${{ env.UNITY_PATH }}"
-
-      - name: Integration Test - Build Standalone Player Sentry SDK
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-build-project.ps1 "${{ env.UNITY_PATH }}"
-
-      - name: Integration Test - Run Player - Smoke Test
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-run-smoke-test.ps1
-


moved to a separate windows-smoke-test job below

We need a Mac and Linux too for standalone. Less relevant until we have native support

yes, seemed a bit pointless to run on those while they're not officially supported yet. Would just take away from the available github-actions runners' pool. So if you don't mind I'd also add them later when needed.

vaind · 2022-02-17T08:38:35Z

.github/workflows/ci.yml

+      - name: Setup Unity
+        uses: getsentry/setup-unity@46c2e082d98cc3a825a5b59038cb31705fe9ff56
+        with:
+          unity-version: ${{ matrix.unity-version }}
+          unity-version-changeset: ${{ matrix.unity-version-changeset }}
+          unity-modules: windows-il2cpp


Windows runners can't use containers because of licensing & the limitations of Windows Server 2022 (no support for WSL2), see actions/runner#904

Therefore we stay with the standard unity setup here

vaind · 2022-02-17T08:39:30Z

samples/unity-of-bugs/Assets/Editor/Builder.cs

@@ -60,6 +60,7 @@ public static void BuildIl2CPPPlayer(BuildTarget buildTarget)

    public static void BuildWindowsIl2CPPPlayer() => BuildIl2CPPPlayer(BuildTarget.StandaloneWindows64);
    public static void BuildMacIl2CPPPlayer() => BuildIl2CPPPlayer(BuildTarget.StandaloneOSX);
+    public static void BuildLinuxIl2CPPPlayer() => BuildIl2CPPPlayer(BuildTarget.StandaloneLinux64);


this ended up unused but I guess we can keep it for now. Later we can fix the smoke test on linux (currently times out)

bruno-garcia · 2022-02-17T10:01:07Z

.github/workflows/ci.yml

@@ -228,19 +146,14 @@ jobs:
      - name: Configure Sentry via the Editor Window
        run: dotnet msbuild /t:UnityConfigureSentryOptions /p:Configuration=Release /p:OutDir=other src/Sentry.Unity

+      # TODO: can we make unity only prepare the project, without compiling it, to unlock the unity license faster? iOS is already built like that.


Yes please. Export gradle project.

Downside is that we don't cover some code path the one that uploads symbols when unity builds an apk. But we anyway have 2 paths to test

We could do the other (=current) path later in another job later on. In any case I'd do this change in a followup PR.

bruno-garcia · 2022-02-17T10:02:01Z

.github/workflows/ci.yml

-      - name: Integration Test - Create new Project
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-create-project.ps1 "${{ env.UNITY_PATH }}"
-
-      - name: Integration Test - Build Standalone Player without Sentry SDK
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-build-project.ps1 "${{ env.UNITY_PATH }}"
-
-      - name: Integration Test - Add Sentry to test project
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-update-sentry.ps1 "${{ env.UNITY_PATH }}"
-
-      - name: Integration Test - Build Standalone Player Sentry SDK
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-build-project.ps1 "${{ env.UNITY_PATH }}"
-
-      - name: Integration Test - Run Player - Smoke Test
-        shell: pwsh
-        run: ./test/Scripts.Integration.Test/integration-run-smoke-test.ps1
-


We need a Mac and Linux too for standalone. Less relevant until we have native support

.github/workflows/ci.yml

vaind mentioned this pull request Feb 15, 2022

Build in linux docker, test on supported platforms #555

Closed

bruno-garcia reviewed Feb 15, 2022

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

vaind force-pushed the chore/build-in-docker branch 11 times, most recently from fe339cf to 3482444 Compare February 16, 2022 09:53

vaind added 8 commits February 16, 2022 13:00

fix: reading Unity version from path

731b307

ci: fix executing unity tests in docker

de2c8aa

previously crashed with https://forum.unity.com/threads/how-to-run-target-platform-tests-in-docker.1163261/#post-7894762

ci: build in a linux docker container

e179e19

RunUnity

cf6f1eb

ci: fix integratio build powershell script

579a56a

test: partial linux support for the integration test

4a14d9e

ci: make sure to cache for UnityCreatePackages target

4994825

ci: disable desktop smoke test temporarily

4f790b7

vaind force-pushed the chore/build-in-docker branch from a26d4c8 to 028eec3 Compare February 16, 2022 12:12

ci: fix missing artifacts

0b9e288

vaind force-pushed the chore/build-in-docker branch from 028eec3 to 0b9e288 Compare February 16, 2022 13:00

ci: fix the tests using invalid platform cache

f30e01f

vaind force-pushed the chore/build-in-docker branch from 8d0611c to f30e01f Compare February 16, 2022 13:37

vaind added 3 commits February 16, 2022 16:25

docker ci: use GHCR docker image

7c145ab

ci: run windows smoke test

45657ff

ci: run windows smoke test, vol. 2

67a7c89

vaind force-pushed the chore/build-in-docker branch from 8edeed5 to 67a7c89 Compare February 16, 2022 21:54

vaind commented Feb 17, 2022

View reviewed changes

vaind marked this pull request as ready for review February 17, 2022 08:58

vaind requested a review from bitsandfoxes as a code owner February 17, 2022 08:58

bruno-garcia approved these changes Feb 17, 2022

View reviewed changes

chore: remove unused argument

7139691

vaind force-pushed the chore/build-in-docker branch from e62ff2c to 7139691 Compare February 17, 2022 10:13

vaind merged commit 964ae20 into main Feb 17, 2022

vaind deleted the chore/build-in-docker branch February 17, 2022 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build in linux docker, test on supported platforms #563

Build in linux docker, test on supported platforms #563

vaind commented Feb 15, 2022 •

edited

Loading

vaind left a comment

vaind Feb 17, 2022 •

edited

Loading

vaind Feb 17, 2022

vaind Feb 17, 2022

bruno-garcia Feb 17, 2022

vaind Feb 17, 2022

vaind Feb 17, 2022

vaind Feb 17, 2022

bruno-garcia Feb 17, 2022

vaind Feb 17, 2022

bruno-garcia Feb 17, 2022

Build in linux docker, test on supported platforms #563

Build in linux docker, test on supported platforms #563

Conversation

vaind commented Feb 15, 2022 • edited Loading

vaind left a comment

Choose a reason for hiding this comment

vaind Feb 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vaind commented Feb 15, 2022 •

edited

Loading

vaind Feb 17, 2022 •

edited

Loading