Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Limit git commit message to first 10 images #3140

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

alex-shpak
Copy link
Contributor

In order to address error mentioned in #1857

ts=2020-06-16T14:06:12.217892013Z caller=loop.go:151 component=sync-loop jobID=2e650640-7405-54e9-1e77-43fa9663e01c state=done success=false err="fork/exec /usr/bin/git: argument list too long"

This PR will change message in case if there are over 10 docker images updated to:

Auto-release multiple (11) images

 - docker.io/image:v1
 - docker.io/image:v10
 - docker.io/image:v11
 - docker.io/image:v2
 - docker.io/image:v3
 - docker.io/image:v4
 - docker.io/image:v5
 - docker.io/image:v6
 - docker.io/image:v7
 - docker.io/image:v8
 ...

In our case issue was that after few failed attempts to commit to git repo there was large amount of automated releases to apply, which resulted in mentioned error.

I hope to merge this fix, it has high impact on our environment.
Thank you!

@alex-shpak
Copy link
Contributor Author

Hi! @stefanprodan @hiddeco
Can you please take a glance at this PR, it is quite small and this issue causes problems for bigger environments.

@matscederholm
Copy link

Serious impact for us, could you please take a look at this?

@hiddeco hiddeco requested a review from squaremo June 26, 2020 10:02
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it would solve the issue to me, but would like @squaremo to have a look too when he is back (next week).

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-shpak alex-shpak force-pushed the bugfix/too-long-git-message branch from b3a2003 to a1125a3 Compare July 7, 2020 17:06
@stefanprodan stefanprodan merged commit a277cd3 into fluxcd:master Jul 8, 2020
@matscederholm
Copy link

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants