This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Put git messages into tmp files #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-shpak
force-pushed
the
bugfix/long-git-note
branch
from
d7f5cd4 to
079100f
Compare
squaremo
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Yep this looks like it'll be OK. How large do the commit messages and notes get? I think it probably is worth cutting down the size of commit messages at least, since they will be painful to look through in git log. But: in terms of making things work again, this is 👍
|
As for commit message, biggest I got so far was 21 images, it is bearable to read. For notes, for big cluster it gets multiple kb of json. P.S. Updated branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #3140 was not enough to fix problem.
This PR will partially revert #3140 and also put git message for
git commitandgit noteinto TMP files. Preventingargs too longerror.