Support Hugo extended #65

satoshun00 · 2018-07-30T19:25:42Z

~~Support npm i args like node-sass (or not).~~
Fallback to normal version.
Update README

satoshun00 · 2018-07-30T19:40:48Z

lib/index.js

@@ -30,17 +33,17 @@ const binNameMap = {
  }
 };
 const binName = (binNameMap[process.platform] && binNameMap[process.platform][process.arch]) || '';
-
+const srcPrefix = `hugo${extended ? '_extended' : ''}_${hugoVersion}_`;


📝 bin-wrapper supports multi files download
/~https://github.com/kevva/bin-wrapper/blob/master/index.js#L165

XhmikosR · 2018-08-06T09:15:23Z

lib/index.js

 const pkg = require('../package');

-const hugoVersion = pkg.hugoVersion;
+const config = pkgConf.sync('hugo-bin');
+const hugoVersion = process.env.HUGO_BIN_VERSION || process.env.npm_config_hugo_bin_version || config.version || pkg.defaultHugoVersion;


Are you sure config.version should be here?

On second thought, supposing checksum feature for the future, it's not make sense to set hugoVersion on user configuration.
Because it would force users to set all of version,os,platform,checksum in their configuraton file.

I remove this line.

satoshun00 · 2018-08-11T10:13:20Z

~~wip removed.~~
~~in-review until next week.~~

I cannot get project root config by pkg-conf correctly because process.cwd() on postinstall process point to hugo-bin package root.

Back to wip.

XhmikosR · 2018-08-12T15:53:30Z

README.md

@@ -8,6 +8,8 @@
 npm install --save-dev hugo-bin
 ```

+hugo-bin now supports [Extended version of Hugo](/~https://github.com/gohugoio/hugo/releases/tag/v0.43). See [Installation options](#installation-options) for more detail.


detail -> details

XhmikosR · 2018-08-12T15:53:47Z

README.md

@@ -42,6 +44,46 @@ npm run create -- 'post/my-new-post' # see below 'npm-run-script'

 See the [Hugo Documentation](https://gohugo.io/) for more information.

+## Installation options
+
+hugo-bin supports options to change variation of Hugo binaries.


to change -> to change the

XhmikosR · 2018-08-12T15:53:58Z

README.md

+
+hugo-bin supports options to change variation of Hugo binaries.
+
+Each options can be configured in the `hugo-bin` section of your `package.json`:


options -> option

XhmikosR · 2018-08-12T15:54:25Z

README.md

+
+Default: `""`
+
+Set it to `extended` to download [extended version](/~https://github.com/gohugoio/hugo/releases/tag/v0.43) binary.


to download -> to download the

XhmikosR · 2018-08-12T15:54:37Z

README.md

+
+Set it to `extended` to download [extended version](/~https://github.com/gohugoio/hugo/releases/tag/v0.43) binary.
+
+If this set to `extended` but it's not available for the user's platform, then the normal version would be downloaded instead.


this -> this is
would be -> will be

satoshun00 · 2018-09-02T12:55:45Z

wip removed.
in-review until next week.

satoshun00 · 2018-09-02T12:58:04Z

README.md

@@ -8,7 +8,7 @@
 npm install --save-dev hugo-bin


fix some grammer mistakes

fix getting project root issue

XhmikosR · 2018-09-05T18:33:15Z

@satoshun00: maybe you could just release the usual, normal version until this is ready? There have been a lot of changes and fixes especially the variables overwrites feature.

XhmikosR · 2018-09-28T18:36:17Z

Friendly ping @satoshun00, see above.

satoshun00 · 2018-10-07T08:15:22Z

@XhmikosR Sorry for late reply.
I would like to release these changes with upgrading hugo to 0.43 because it's difficult to manage breaking changes and versions.

I think followings may be easy to understand.

v0.31.0 -> hugo-0.43 and these changes
v0.32.0 -> hugo-0.44
...

I'll merge these changes and start integration test.

XhmikosR · 2018-10-07T10:54:43Z

lib/index.js

  .use(binName);
+module.exports = projectRoot => {
+  const config = pkgConf.sync('hugo-bin', { cwd: projectRoot });
+  const extended = (process.env.HUGO_BIN_BUILD_TAGS || process.env.npm_config_hugo_bin_build_tags || config.buildTags || '') === 'extended';


@satoshun00: I wonder, is the || '' needed? Because later in the return statement you check for this anyway.

oops || '' is not needed!

wip: Support Hugo extended

528d589

satoshun00 commented Jul 30, 2018

View reviewed changes

XhmikosR reviewed Aug 6, 2018

View reviewed changes

fallback support, update readme.md

c057b36

satoshun00 changed the title ~~wip: Support Hugo extended~~ Support Hugo extended Aug 11, 2018

satoshun00 changed the title ~~Support Hugo extended~~ wip: Support Hugo extended Aug 11, 2018

XhmikosR reviewed Aug 12, 2018

View reviewed changes

fixup! wip: Support Hugo extended

d962e8d

satoshun00 changed the title ~~wip: Support Hugo extended~~ Support Hugo extended Sep 2, 2018

satoshun00 commented Sep 2, 2018

View reviewed changes

README.md

@@ -8,7 +8,7 @@

npm install --save-dev hugo-bin

Copy link

Member Author

satoshun00 Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix some grammer mistakes

fix getting project root issue

satoshun00 merged commit 1113135 into fenneclab:master Oct 7, 2018

satoshun00 deleted the feat/extended branch October 7, 2018 08:15

XhmikosR reviewed Oct 7, 2018

View reviewed changes

satoshun00 mentioned this pull request Oct 14, 2018

Remove unneeded condition. #75

Merged

satoshun00 mentioned this pull request Dec 10, 2021

Remove the npm projectRoot workaround #115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Hugo extended #65

Support Hugo extended #65

satoshun00 commented Jul 30, 2018 •

edited

Loading

satoshun00 Jul 30, 2018

XhmikosR Aug 6, 2018

satoshun00 Aug 11, 2018

satoshun00 commented Aug 11, 2018 •

edited

Loading

XhmikosR Aug 12, 2018

XhmikosR Aug 12, 2018

XhmikosR Aug 12, 2018

XhmikosR Aug 12, 2018

XhmikosR Aug 12, 2018

satoshun00 commented Sep 2, 2018

satoshun00 Sep 2, 2018

XhmikosR commented Sep 5, 2018

XhmikosR commented Sep 28, 2018

satoshun00 commented Oct 7, 2018

XhmikosR Oct 7, 2018

satoshun00 Oct 7, 2018


		hugo-bin supports options to change variation of Hugo binaries.

		Each options can be configured in the `hugo-bin` section of your `package.json`:


		Default: `""`

		Set it to `extended` to download [extended version](/~https://github.com/gohugoio/hugo/releases/tag/v0.43) binary.


		Set it to `extended` to download [extended version](/~https://github.com/gohugoio/hugo/releases/tag/v0.43) binary.

		If this set to `extended` but it's not available for the user's platform, then the normal version would be downloaded instead.

Support Hugo extended #65

Support Hugo extended #65

Conversation

satoshun00 commented Jul 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satoshun00 commented Aug 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satoshun00 commented Sep 2, 2018

Choose a reason for hiding this comment

XhmikosR commented Sep 5, 2018

XhmikosR commented Sep 28, 2018

satoshun00 commented Oct 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satoshun00 commented Jul 30, 2018 •

edited

Loading

satoshun00 commented Aug 11, 2018 •

edited

Loading