Remove the npm projectRoot workaround #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
rm-projectRoot
branch
from
490a61b to
44fffa0
Compare
XhmikosR
force-pushed
the
rm-projectRoot
branch
from
44fffa0 to
8643ae9
Compare
|
I think this is still valid. |
|
Weird, I tested it and it works fine for me using Node.js 16 and npm 8.x. Can you test it again please? |
|
Closing, it's indeed still needed... In theory, we are doing something wrong, but I don't have the time to investigate it further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@satoshun00 is this still valid? I quickly tested this and it seems it's not needed.