Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restrictions for synthetic _source #1622

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Jan 10, 2025

This adds the restrictions described in #1618 to the Enabling and disabling advanced indexing features for Fleet-managed data streams page.

I also removed some extra spacing which I must have added earlier by accident.

@lucabelluccini and @martijnvg, please check that I have the enable and disable code examples right, since I'm kind of guessing.

Closes: #1618

Previews:


Screenshot 2025-01-21 at 9 40 23 AM
Screenshot 2025-01-21 at 9 40 03 AM

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Jan 17, 2025

@lucabelluccini, @martijnvg Please let me know if the warning and code samples look okay.

Just trying to wrap things up since all docs PRs need to be merged by Jan.29. Thanks!

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments.
Additionally in the screenshot, I see the _source.mode mapping attribute being used. Can this be removed in favor for the index.mapping.source.mode index setting?

@@ -878,10 +863,11 @@ For example, the following payload disables TSDS on `nginx.stubstatus`:
[[data-streams-advanced-synthetic-enable]]
== Enable synthetic `_source`

Note that synthetic `_source` is supported only on non-TSDS data streams.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synthetic source is also supported on tsds data streams. I think this line can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martijnvg. I can remove the line, but from @lucabelluccini's issue: I've tested it on 8.17 and it's impossible to disable Synthetic _source on a TSDS data stream.

For now I've changed it to Note that disabling synthetic _source is supported only on non-TSDS data streams.
Please let me know if that's not what we want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the issue: #1618 (comment)

Let's see what went wrong here.

docs/en/ingest-management/data-streams.asciidoc Outdated Show resolved Hide resolved
@kilfoyle
Copy link
Contributor Author

Thanks Martijn!

. Additionally in the screenshot, I see the _source.mode mapping attribute being used. Can this be removed in favor for the index.mapping.source.mode index setting?

Oops. I left the old version by accident so it's removed now.

Please see my other comment above about disabling synthetic _source.

@kilfoyle kilfoyle requested a review from martijnvg January 20, 2025 14:31
@kilfoyle
Copy link
Contributor Author

kilfoyle commented Jan 21, 2025

@martijnvg, @lucabelluccini Based on discussion in #1618 (comment) I've removed the note about disabling Synthetic _source not being supported on on TSDS data streams.

I've updated the PR description with the latest screen captures. Please let me know if it looks okay now. Thanks!

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@kilfoyle kilfoyle merged commit 42b052f into elastic:main Jan 21, 2025
3 checks passed
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
* Add restrictions for synthetic

* Fixes for Martijn's review

* Remove note about synthetic _source not supported on TSDS

(cherry picked from commit 42b052f)
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
* Add restrictions for synthetic

* Fixes for Martijn's review

* Remove note about synthetic _source not supported on TSDS

(cherry picked from commit 42b052f)
kilfoyle added a commit that referenced this pull request Jan 21, 2025
* Add restrictions for synthetic

* Fixes for Martijn's review

* Remove note about synthetic _source not supported on TSDS

(cherry picked from commit 42b052f)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle added a commit that referenced this pull request Jan 21, 2025
* Add restrictions for synthetic

* Fixes for Martijn's review

* Remove note about synthetic _source not supported on TSDS

(cherry picked from commit 42b052f)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet][Synthetic _source] Licensing comments and update to avoid deprecation warnings
4 participants