-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restrictions for synthetic _source
#1622
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
@lucabelluccini, @martijnvg Please let me know if the warning and code samples look okay. Just trying to wrap things up since all docs PRs need to be merged by Jan.29. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments.
Additionally in the screenshot, I see the _source.mode mapping attribute being used. Can this be removed in favor for the index.mapping.source.mode index setting?
@@ -878,10 +863,11 @@ For example, the following payload disables TSDS on `nginx.stubstatus`: | |||
[[data-streams-advanced-synthetic-enable]] | |||
== Enable synthetic `_source` | |||
|
|||
Note that synthetic `_source` is supported only on non-TSDS data streams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synthetic source is also supported on tsds data streams. I think this line can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martijnvg. I can remove the line, but from @lucabelluccini's issue: I've tested it on 8.17 and it's impossible to disable Synthetic _source on a TSDS data stream.
For now I've changed it to Note that disabling synthetic _source is supported only on non-TSDS data streams.
Please let me know if that's not what we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented on the issue: #1618 (comment)
Let's see what went wrong here.
Thanks Martijn!
Oops. I left the old version by accident so it's removed now. Please see my other comment above about disabling synthetic _source. |
@martijnvg, @lucabelluccini Based on discussion in #1618 (comment) I've removed the note about disabling Synthetic _source not being supported on on TSDS data streams. I've updated the PR description with the latest screen captures. Please let me know if it looks okay now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎸
This adds the restrictions described in #1618 to the Enabling and disabling advanced indexing features for Fleet-managed data streams page.
I also removed some extra spacing which I must have added earlier by accident.
@lucabelluccini and @martijnvg, please check that I have the
enable
anddisable
code examples right, since I'm kind of guessing.Closes: #1618
Previews: