Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet][Synthetic _source] Licensing comments and update to avoid deprecation warnings #1618

Closed
lucabelluccini opened this issue Jan 10, 2025 · 3 comments · Fixed by #1622
Closed
Assignees

Comments

@lucabelluccini
Copy link
Contributor

lucabelluccini commented Jan 10, 2025

The page https://www.elastic.co/guide/en/fleet/current/data-streams-advanced-features.html must be updated to:

  • Highlight that Synthetic _source requires an enterprise license starting 8.17.0 onwards
  • Due to the deprecation Deprecate _source.mode in mappings elasticsearch#116689, we must not tell users to use "mappings._source.mode": "synthetic" but instead use "settings.index.mapping.source.mode": "synthetic"
  • We should tell that the procedure to disable Synthetic _source can work only in data streams which are not TSDS. I've tested it on 8.17 and it's impossible to disable Synthetic _source on a TSDS data stream.
    • Afaik, across integrations, all data streams use TSDS and none use Synthetic _source explicitly.
    • We might consider completely removing Synthetic _source guide.

FYI @martijnvg (Elasticsearch) & @kilfoyle

@martijnvg
Copy link
Member

We should tell that the procedure to disable Synthetic _source can work only in data streams which are not TSDS. I've tested it on 8.17 and it's impossible to disable Synthetic _source on a TSDS data stream.
Afaik, across integrations, all data streams use TSDS and none use Synthetic _source explicitly.
We might consider completely removing Synthetic _source guide.

@lucabelluccini How did you disable synthetic source in tsds data streams? You should be able to disable by configuring index.mapping.source.mode=stored.

@lucabelluccini
Copy link
Contributor Author

Hello @martijnvg
I'm sorry but I didn't update the issue following the email thread we had internally.

Yes, it is possible to disable syn _source with TSDS. I was testing on an already existing index created prior 8.17.

I've updated the main issue text

@kilfoyle
Copy link
Contributor

Thanks @lucabelluccini! I've fixed up the PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants