Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version compatibility statement #1537

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

kilfoyle
Copy link
Contributor

This rephrases the version compatibility statement in the Fleet Server install docs to be a little bit more clear.

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thought to take or leave

@@ -30,8 +30,7 @@ image::images/fleet-server-cloud-deployment.png[{fleet-server} Cloud deployment
{fleet-server} is compatible with the following Elastic products:

* {stack} 7.13 or later.
** For version compatibility: {es} >= {fleet-server} >= {agent} (except for
bugfix releases)
** For version compatibility, {es} must be at the same or a later version than {fleet-server}, and {fleet-server} needs to be at the same or a later version than {agent} (not including patch releases).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we call this "minor" then, if it doesn't consider patches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this before merging. I don't think saying "minor" would be correct. Elasticsearch must be at a higher version, including both major and minor, but not patch.

@kilfoyle kilfoyle merged commit 156f83e into elastic:main Dec 16, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
kilfoyle added a commit that referenced this pull request Dec 16, 2024
(cherry picked from commit 156f83e)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle added a commit that referenced this pull request Dec 16, 2024
(cherry picked from commit 156f83e)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@eedugon
Copy link
Contributor

eedugon commented Dec 18, 2024

Not sure why, but I totally missed the ping in this PR. Anyway it looked great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants