-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet Server on kubernetes document proposal #1518
base: main
Are you sure you want to change the base?
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @eedugon? 🙏
|
@eedugon I read through and this looks great! |
I still need to add the main kubernetes-related steps and also review all the content as it was written through a lot of iterations and text replacements :)
Feel free to review and make comments, in the PR or in private. Now or at a later stage, whatever you prefer.
A lot of sentences will definitely need improvement as they are currently more the ideas “I want to express” without thinking much on “how to express them”, so I’m sure your feedback will help a lot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I through in a few small grammar things, but generally liking the new flow!
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes-content.asciidoc
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes-content.asciidoc
Outdated
Show resolved
Hide resolved
…ntent.asciidoc Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have talked in private, I suggest:
- Add some context for quickstart and Production mode
- Add a link to the environment variables available for fleet server https://www.elastic.co/guide/en/fleet/current/agent-environment-variables.html
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes.asciidoc
Outdated
Show resolved
Hide resolved
…fleet_server_k8s_install
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
…ciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@kilfoyle, after reviewing and applying the latest updates to the doc together I'd like devs to review the content from the technical side also. @swiatekm : would you be able to take a look and share your thoughts? I'd like your comments around the specific proposal to install the Fleet Server on Kubernetes. We are suggesting a single If you believe there's a quicker or better approach let us know. I haven't tried the automatic Kibana Setup directly by the Agent (using KIBANA_ env vars) because I've never been able to make it working (that functionality is not properly documented either). cc: @nimarezainia : we would also like you to review this new document :) |
@eedugon I did a first pass review and everything looks good to me. Before approving, I'm also going to actually follow the guide as well in my test environment to see if I spot any sharp edges that way. One note for the future is that the CA setup seems like the most complex part of the guide. While we can't do much about this when it comes to ES itself, for the connection between Fleet Server and agent, we should be able to have the Fleet Server Helm Chart generate the necessary certs, or, even better, have cert-manager do it if it's available. WDYT @pkoutsovasilis ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few issues, comments below.
kubectl create secret generic fleet-server-certs \ | ||
--from-file=es-ca.crt=<PATH_TO_ES_CA_CERT_FILE> \ <1> | ||
--from-file=fleet-server.crt=<PATH_TO_FLEET_SERVER_CERT> \ <2> | ||
--from-file=fleet-server.key=<PATH_TO_FLEET_SERVER_CERT_KEY> <3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\ <1>
ends up rendering a space after each backslash, which isn't valid shell escaping, and will produce an error. Not sure how to fix it in asciidoc.
docs/en/ingest-management/fleet/add-fleet-server-kubernetes-content.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-kubernetes-content.asciidoc
Show resolved
Hide resolved
Thanks a lot!
I will work on that.
Thanks for raising the issue when using the cert and key. I’ve realized
that I didn’t test that part!!
|
…ntent.asciidoc Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
…ntent.asciidoc Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
sorry for the delay guys 👋 I will review this shortly 🙂 |
Adding a
Deploy Fleet Server on Kubernetes
document, underDeployment models
section.Preview: https://ingest-docs_bk_1518.docs-preview.app.elstc.co/guide/en/fleet/master/add-fleet-server-kubernetes.html