Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Tar APIs #67883
Implement Tar APIs #67883
Changes from all commits
e9fbcc9
0731cb2
8f1f1af
10df463
da4af67
8710ceb
76e484c
c9c4d85
e0dafda
5b8392b
a16d4d9
7ca674e
560b789
b3e5988
c22a8e7
d3e4f31
23caa17
e0b0442
b682576
9fd01c3
7b0d8c3
f1d9b7b
0980fbd
a28f3e5
7f2e516
3f71b60
cb855ed
dd40447
9a28f12
40097c6
b1e8dfc
c11e434
255ec96
8ae7788
d3cbdd2
6b5d078
19eb98d
69ca3e7
b1a2d5a
fb644dd
cd40d62
0ee2c33
58a3476
fc0e568
5d81577
a52dfe4
b227fa9
5745b9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: make
dev
argument type match type ofFileStatus.Dev
. Either useulong
orlong
for both.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StringBuilder indexing is expensive, so the below has non-trivial expense. StringBuilder is also unnecessary here. And this ends up allocating a new string (and StringBuilder) even if nothing needs to be changed.
This method should instead be more like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(There should also be a comment about why these are invalid. Don't we typically leave such decisions up to the OS now?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was originally merged in another PR. I merely renamed the class so it would make sense for usage in both zip and tar.
#67332
Since it isn't really new code, I would like to address this suggestion in a future PR.