Implement Tar APIs #67883

carlossanlop · 2022-04-12T02:13:11Z

Fixes #65951

Approved proposal in this comment: #65951 (comment)

It's ready to review but I still have some small TODOs to address.

Some tests depend on the runtime-assets that need to be merged first: Add System.Formats.Tar test assets runtime-assets#238
Need to implement the latest stream-based TarFile methods.
Async methods (might submit them in a separate PR if that's ok).
Some Unix-specific syscall issues. @eerhardt @tmds I would appreciate if you could help me with those. I'll tag you.

cc @baronfel

ghost · 2022-04-12T02:13:15Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #65951

It's ready to review but I still have some small TODOs to address.

Some tests depend on the runtime-assets that need to be merged first: Add System.Formats.Tar test assets runtime-assets#238
Need to implement the latest stream-based TarFile methods.
Async methods (might submit them in a separate PR if that's ok).
Some Unix-specific syscall issues. @eerhardt @tmds I would appreciate if you could help me with those. I'll tag you.

cc @baronfel

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.IO`
Milestone:	7.0.0

dotnet-issue-labeler · 2022-04-12T02:13:19Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

src/libraries/System.Formats.Tar/src/Resources/Strings.resx

src/libraries/System.Formats.Tar/tests/TarTestsBase.Gnu.cs

danmoseley · 2022-04-12T03:47:43Z

src/libraries/System.Formats.Tar/tests/WrappedStream.cs

+
+using System.IO;
+
+namespace System.Formats.Tar


can we share the existing WrappedStream.cs by moving it into Common?

We actually have one already being shared, but I needed to slightly modify it for my own purposes and didn't want to break the other tests depending on it. So that's why I had to copy it here.

It's very similar. I wonder if there's a way to parameterize a single copy.

danmoseley · 2022-04-12T16:29:24Z

I didn't review properly - someone else will need to 😃

src/libraries/Common/src/Interop/Unix/System.Native/Interop.DeviceFiles.cs

src/libraries/System.Formats.Tar/src/System/Formats/Tar/GnuTarEntry.cs

stephentoub · 2022-04-12T16:09:17Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/GnuTarEntry.cs

+            get => _header._aTime;
+            set
+            {
+                // TODO: Is there a max value?


In general what's the plan for all these TODOs?

Address them before merging.

If we start getting close to the Preview 4 snap such that the merge is at-risk, I'd also be open to filing a follow-up issue for any of the TODOs that aren't blocking, for them to be addressed in Preview 5.

I can collect a list of the pending TODOs into a comment so we can document them in this preview as features that won't yet be fully working.

src/libraries/System.Formats.Tar/src/System/Formats/Tar/PaxTarEntry.cs

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Read.cs

stephentoub · 2022-04-12T18:32:56Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Read.cs

+            StringSplitOptions splitOptions = StringSplitOptions.RemoveEmptyEntries;
+
+            string[] attributeArray = nextLine.Split(' ', 2, splitOptions);
+            if (attributeArray.Length != 2)
+            {
+                return false;
+            }
+
+            string[] keyAndValueArray = attributeArray[1].Split('=', 2, splitOptions);
+            if (keyAndValueArray.Length != 2)
+            {
+                return false;
+            }
+
+            key = keyAndValueArray[0];
+            value = keyAndValueArray[1];


It'd be much more efficient to parse this with IndexOf rather than Split

stephentoub · 2022-04-12T18:33:45Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs

+        private static readonly byte[] s_paxMagic = new byte[] { 0x75, 0x73, 0x74, 0x61, 0x72, 0x0 }; // "ustar\0"
+        private static readonly byte[] s_paxVersion = new byte[] { 0x30, 0x30 }; // "00"
+
+        private static readonly byte[] s_gnuMagic = new byte[] { 0x75, 0x73, 0x74, 0x61, 0x72, 0x20 }; // "ustar "
+        private static readonly byte[] s_gnuVersion = new byte[] { 0x20, 0x0 }; // " \0"


Can these be spans instead? e.g.

private static ReadOnlySpan<byte> PaxMagic => new byte[] { ... };

?

I noticed the suggestion is a property. Is this smart enough to cache the array, instead of returning new byte[] every time it is called?

I changed this, but I'm still curious. I suspect the answer is that it gets cached.

Roslyn has an optimization to refer to the static data segment of the assembly. So no allocation happens here.
See sharplab.

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs

stephentoub · 2022-04-12T18:34:51Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs

+            checksum += WriteRightAlignedBytesAndGetChecksum(uidBytes, _uidBytes);
+
+            byte[] gidBytes = TarHelpers.GetAsciiBytes(TarHelpers.ConvertDecimalToOctal(_gid));
+            checksum += WriteRightAlignedBytesAndGetChecksum(gidBytes, _gidBytes);


I'll stop commenting on these, too, but there are more efficient ways to do this rather than allocating new byte[]s each time.

Fixed with ArrayPool.

carlossanlop · 2022-04-14T06:39:18Z

I seem to have generated the tar and tar.gz files from runtime-testdata with the wrong uid and gid, so some tests will fail due to that. I'll have to generate them again with the script and update the package here.

Edit: Fixed.

src/libraries/Common/src/Interop/Unix/System.Native/Interop.DeviceFiles.cs

tmds · 2022-04-14T07:44:36Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.Unix.cs

+            // If the permissions weren't set at all, don't write the file's permissions.
+            if (permissions != 0)
+            {
+                Interop.CheckIo(Interop.Sys.FChMod(handle, permissions), destinationFileName);


Unlike tar this doesn't respect umask while extracting.

See my elaborate comment here: #67883 (comment).

I think we want to respect the umask since that is something that protects the user for unintentionally opening up permissions.

To do that, you can call the internal SafeHandle.Open on Unix that accepts Interop.Sys.Permissions:

runtime/src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs

Lines 185 to 190 in dbf5c58

internal static SafeFileHandle Open(string fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, long preallocationSize,

Interop.Sys.Permissions openPermissions = DefaultOpenPermissions,

Func<Interop.ErrorInfo, Interop.Sys.OpenFlags, string, Exception?>? createOpenException = null)

{

return Open(fullPath, mode, access, share, options, preallocationSize, openPermissions, out _, out _, createOpenException);

}

Per that comment, at some point we'll also want to support applying all permissions (including sticky, setgroup, setuser), and setting ownership (uid, gid). The API will need to be extended to support that use-case.

cc @eerhardt

tmds · 2022-04-14T07:46:53Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.Unix.cs

+            const int ExtractPermissionMask = 0x1FF;
+            int permissions = (int)Mode & ExtractPermissionMask;
+
+            // If the permissions weren't set at all, don't write the file's permissions.


// If the permissions weren't set at all

Why are we ignoring permissions when none are set?

I saw your other comment. This is probably wrong so I'll fix it.

tmds · 2022-04-14T08:10:33Z

tar files have permissions and ownership information.
The tar command has flags that controls these.

By default:

For a regular user, tar will not set the owner, and filter out priviledged bits from the permissions (because the user can't set them). The process umask is respected.
For root, tar will set the owner, and set all permission bits. The process umask is ignored.

The implementation isn't considering ownership at the moment, and the permission bits get filtered for priviledged bits but the umask gets ignored.

I think we should default to the regular user tar behavior.

To be able to opt into the other mode, the API will need to be extended. This doesn't need to happen now if only the default mode should be supported. Though maybe you want to take it into account already, and for example introduce ExtractOptions and add Overwrite to it instead of making it an argument.

src/libraries/Common/src/System/IO/Compression/Archiving.Utils.cs

src/libraries/System.Formats.Tar/src/System/Formats/Tar/FieldLengths.cs

adamsitnik · 2022-04-14T17:34:29Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/GnuTarEntry.cs

+        /// <item>In all platforms: <see cref="TarEntryType.Directory"/>, <see cref="TarEntryType.HardLink"/>, <see cref="TarEntryType.SymbolicLink"/>, <see cref="TarEntryType.RegularFile"/>.</item>
+        /// <item>In Unix platforms only: <see cref="TarEntryType.BlockDevice"/>, <see cref="TarEntryType.CharacterDevice"/> and <see cref="TarEntryType.Fifo"/>.</item>
+        /// </list>
+        /// </remarks>


would it be possible to use inheritdoc and avoid the need of having dedicated docs for methods that just call base class implementation?

src/libraries/System.Formats.Tar/src/System/Formats/Tar/SubReadStream.cs

src/libraries/System.Formats.Tar/src/System/Formats/Tar/SeekableSubReadStream.cs

src/libraries/System.Formats.Tar/src/System/Formats/Tar/SubReadStream.cs

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs

adamsitnik · 2022-04-14T18:05:29Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs

+
+        public Task ExtractToFileAsync(string destinationFileName, bool overwrite, CancellationToken cancellationToken = default)
+        {
+            throw new NotImplementedException();


I assume it's on the TODO list?

Yes, async will have to be implemented later.

If we're not going to implement these as part of this PR, I'd prefer they be removed, at least from the ref, until they're implemented. It's otherwise a bad experience to add new APIs that aren't yet implemented.

No problem. Removing them from the ref.

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs

adamsitnik · 2022-04-14T18:11:42Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.cs

+    // - POSIX IEEE 1003.1-2001 ("POSIX.1") Pax Interchange Tar Format (pax).
+    // - GNU Tar Format (gnu).
+    // Documentation: https://www.freebsd.org/cgi/man.cgi?query=tar&sektion=5
+    internal partial struct TarHeader


this struct seems to be very large and I would not expect it to get us some perf. What are we getting by keeping it a struct?

Would you prefer if I use class? And maybe split it into internal class TarHeaderRead and internal class TarHeaderWrite?

I expect us to get no perf benefits from keeping it struct, while we can run into issues like modifying a copy instead:

TarHeader header = new(); header._mode = 1; SetMode(header); Console.WriteLine(header._mode); // prints 1 as we have passed struct copy to SetMode and modified a copy static void SetMode(TarHeader h) => h._mode = 2;

src/libraries/System.Formats.Tar/src/System.Formats.Tar.csproj

src/native/libs/System.Native/pal_io.h

src/libraries/Common/src/Interop/Unix/System.Native/Interop.DeviceFiles.cs

… individual links.

…ntry keeps getting called.

…he first null entry.

…d condition to symlink tests that checks if system can create symlinks.

adamsitnik · 2022-04-21T10:10:10Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/GnuTarEntry.cs

+                if (value < DateTimeOffset.UnixEpoch)
+                {
+                    throw new ArgumentOutOfRangeException(nameof(value));
+                }


Checking current time is expensive. IMO the current implementation (having only the UnixEpoch check) is all we need.

adamsitnik · 2022-04-21T10:12:33Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/SeekableSubReadStream.cs

+    // Does not support writing.
+    internal sealed class SeekableSubReadStream : SubReadStream
+    {
+        public SeekableSubReadStream(Stream superStream, long startPosition, long maxLength)


Can we call these something other than "sub" and "super"? I find the terminology confusing.

@stephentoub SuperSubmarineStream? ;)

adamsitnik · 2022-04-21T10:17:12Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs

+
+            _header = default;
+
+            _header._extendedAttributes = new Dictionary<string, string>();


Fixed. Now I lazy-initialize this field.

@carlossanlop have you pushed these changes? I can still see _header._extendedAttributes = new Dictionary<string, string>();

adamsitnik · 2022-04-21T10:18:50Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs

+        public int Uid
+        {
+            get => _header._uid;
+            set => _header._uid = value;


Should we re-propose this as uint instead of int?

That would be my preference, but get ready for a lot of pushback at the review :)

adamsitnik · 2022-04-21T10:23:42Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs

+            // If the path can be extracted in the specified destination directory, returns the full path with sanitized file name. Otherwise, throws.
+            static string GetSanitizedFullPath(string destinationDirectoryFullPath, string path, string exceptionMessage)
+            {
+                string actualPath = Path.Join(Path.GetDirectoryName(path), ArchivingUtils.SanitizeEntryFilePath(Path.GetFileName(path)));


perf: since Path.GetFileName returns only a substring of the provided path, we could use the overload that returns ReadOnlySpan<char> here and make SanitizeEntryFilePath accept ROS and avoid additional string allocation

adamsitnik · 2022-04-21T10:28:59Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs

+            {
+                string actualPath = Path.Join(Path.GetDirectoryName(path), ArchivingUtils.SanitizeEntryFilePath(Path.GetFileName(path)));
+
+                if (!Path.IsPathFullyQualified(actualPath))


just for my education: for what input this could be true?

adamsitnik · 2022-04-21T10:35:33Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarEntry.cs

+            {
+                throw new IOException(string.Format(SR.IO_AlreadyExists_Name, filePath));
+            }
+            File.Delete(filePath);


why would we like to remove the file now, if the method can still throw few checks later?

If we want to overwrite a file we can use FileMode.Create when creating a FileStream:

Specifies that the operating system should create a new file. If the file already exists, it will be overwritten.

adamsitnik · 2022-04-21T10:45:22Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarFile.cs

+            if (Path.Exists(destinationFileName))
+            {
+                throw new IOException(string.Format(SR.IO_FileExists_Name, destinationFileName));
+            }
+
+            using FileStream fs = File.Create(destinationFileName, bufferSize: 0x1000, FileOptions.None);


if you create FileStream with FileMode.CreateNew it's going to throw if the file already exists.

Suggested change

if (Path.Exists(destinationFileName))

{

throw new IOException(string.Format(SR.IO_FileExists_Name, destinationFileName));

}

using FileStream fs = File.Create(destinationFileName, bufferSize: 0x1000, FileOptions.None);

using FileStream fs = new (destinationFileName, FileMode.CreateNew, FileAccess.Write);

adamsitnik · 2022-04-21T10:51:17Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarFile.cs

+                        Debug.Assert(entryNameLength > 0);
+
+                        bool isDirectory = file.Attributes.HasFlag(FileAttributes.Directory);
+                        string entryName = ArchivingUtils.EntryFromPath(file.FullName, basePath.Length, entryNameLength, ref entryNameBuffer, appendPathSeparator: isDirectory);


not related to your PR: I find it unintuitive that a buffer rented from array pool is passed by reference to a helper method. I needed to verify that the helper method returns the buffer to the pool in case it's too small.

Is there anything I should do on my code to help improve its readability? Or maybe should we open an issue to discuss it separately?

You can just do the rent/return inside EntryFromPath as an implementation detail.

adamsitnik · 2022-04-21T10:57:35Z

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.cs

+    // - POSIX IEEE 1003.1-2001 ("POSIX.1") Pax Interchange Tar Format (pax).
+    // - GNU Tar Format (gnu).
+    // Documentation: https://www.freebsd.org/cgi/man.cgi?query=tar&sektion=5
+    internal partial struct TarHeader


I expect us to get no perf benefits from keeping it struct, while we can run into issues like modifying a copy instead:

TarHeader header = new(); header._mode = 1; SetMode(header); Console.WriteLine(header._mode); // prints 1 as we have passed struct copy to SetMode and modified a copy static void SetMode(TarHeader h) => h._mode = 2;

carlossanlop · 2022-04-21T15:36:38Z

The 3 test failures are unrelated to my changes.

adamsitnik

As discussed, offline, let's merge it now, include in Preview4 and address remaining feedback later (#68230).

Big thanks for you work @carlossanlop !

carlossanlop · 2022-04-21T15:58:54Z

Thanks Adam! I'll add your latest feedback to the follow-up issue checklist.

carlossanlop · 2022-04-21T16:14:30Z

/backport to release/7.0-preview4

github-actions · 2022-04-21T16:14:48Z

Started backporting to release/7.0-preview4: /~https://github.com/dotnet/runtime/actions/runs/2203040454

github-actions · 2022-04-21T16:16:23Z

@carlossanlop backporting to release/7.0-preview4 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Implement Tar APIs
Applying: Address some comment suggestions.
Applying: Add SystemFormatsTarTestData package dependency entries and versions.
Applying: Merge the major and minor p/invokes into a single one.
Applying: Address exception and nullability suggestions.
Applying: Adjust tests for the latest suggestions.
Applying: Document elevation requirement to extract device files on Unix.
Applying: Add tests to verify extraction without elevation throws for device files. Rename file for TarFile Extraction to filesystem.
Applying: Add separate expected mode for special files from assets (644).
Applying: Bump assets version to one with the fix
error: sha1 information is lacking or useless (eng/Versions.props).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0010 Bump assets version to one with the fix
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

API proposal: dotnet#65951

* Implement Tar APIs (#67883) API proposal: #65951 * Add assembly to NetCoreAppLibrary.props * Remove <PackageDescription> from src csproj since it is not OOB. * Add NetCoreAppCurrent to src csproj TargetFrameworks * Additional src csproj changes. * Allow sharing of input tar file for read Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Dan Moseley <danmose@microsoft.com>

carlossanlop added the area-System.IO label Apr 12, 2022

carlossanlop added this to the 7.0.0 milestone Apr 12, 2022

carlossanlop requested review from tmds, jeffhandley, stephentoub, adamsitnik, eerhardt, ericstj, bartonjs and jozkee April 12, 2022 02:13

carlossanlop self-assigned this Apr 12, 2022

dotnet-issue-labeler bot added the new-api-needs-documentation label Apr 12, 2022

danmoseley reviewed Apr 12, 2022

View reviewed changes

src/libraries/System.Formats.Tar/src/Resources/Strings.resx Outdated Show resolved Hide resolved

danmoseley reviewed Apr 12, 2022

View reviewed changes

src/libraries/System.Formats.Tar/src/Resources/Strings.resx Outdated Show resolved Hide resolved

danmoseley reviewed Apr 12, 2022

View reviewed changes

src/libraries/System.Formats.Tar/tests/TarTestsBase.Gnu.cs Outdated Show resolved Hide resolved

danmoseley reviewed Apr 12, 2022

View reviewed changes

stephentoub reviewed Apr 12, 2022

View reviewed changes

carlossanlop force-pushed the tar branch from 6776104 to 138aff8 Compare April 13, 2022 07:12

tmds reviewed Apr 14, 2022

View reviewed changes

src/libraries/Common/src/Interop/Unix/System.Native/Interop.DeviceFiles.cs Show resolved Hide resolved

tmds reviewed Apr 14, 2022

View reviewed changes

carlossanlop commented Apr 14, 2022

View reviewed changes

src/libraries/Common/src/System/IO/Compression/Archiving.Utils.cs Outdated Show resolved Hide resolved

adamsitnik reviewed Apr 14, 2022

View reviewed changes

eerhardt reviewed Apr 14, 2022

View reviewed changes

src/libraries/System.Formats.Tar/src/System.Formats.Tar.csproj Outdated Show resolved Hide resolved

eerhardt reviewed Apr 14, 2022

View reviewed changes

Fix test parsing a double, ensure it uses invariant culture.

58a3476

runfoapp bot mentioned this pull request Apr 20, 2022

System.Diagnostics.Tests.InstanceDataTests.InstanceDataCollectionCollection_CopyTo failing in CI #68291

Closed

carlossanlop added 2 commits April 20, 2022 13:27

More tests parsing a double, ensure invariant culture comparison.

fc0e568

Verify link targets when extracting to directory. Disallow extracting…

5d81577

… individual links.

runfoapp bot mentioned this pull request Apr 20, 2022

EMSDK-.WasmNativeDefaultsTests work item failing #67887

Closed

carlossanlop and others added 3 commits April 20, 2022 16:52

Avoid advancing stream anymore if end markers were found and GetNextE…

a52dfe4

…ntry keeps getting called.

Add test that verifies stream is not advanced anymore after reading t…

b227fa9

…he first null entry.

Fix bug preventing correct generation of full path for extraction. Ad…

5745b9f

…d condition to symlink tests that checks if system can create symlinks.

adamsitnik reviewed Apr 21, 2022

View reviewed changes

adamsitnik approved these changes Apr 21, 2022

View reviewed changes

carlossanlop merged commit 2389815 into dotnet:main Apr 21, 2022

carlossanlop deleted the tar branch April 21, 2022 16:01

carlossanlop added a commit to carlossanlop/runtime that referenced this pull request Apr 21, 2022

Implement Tar APIs (dotnet#67883)

876c3bd

API proposal: dotnet#65951

carlossanlop mentioned this pull request Apr 21, 2022

[release/7.0-preview4] Backport new Tar APIs #68337

Merged

runfoapp bot mentioned this pull request Apr 21, 2022

Read_Archive_File failing due to access denied to tar/pax/file.tar #68357

Closed

akoeplinger mentioned this pull request Apr 22, 2022

Extract_HardLinkEntry_TargetInsideDirectory test from System.Formats.Tar.Tests fails on Android/iOS/tvOS #68360

Open

carlossanlop mentioned this pull request Apr 27, 2022

What's new in .NET 7 Preview 4 [WIP] dotnet/core#7378

Closed

This was referenced May 6, 2022

[API Proposal]: Merge TarEntry's DeviceMajor and DeviceMinor into a single API #68974

Closed

Address some System.Formats.Tar TODOs (infra and syscalls) #69107

Merged

carlossanlop mentioned this pull request May 24, 2022

How to properly set umask in TarEntry and ZipFileExtensions #69760

Closed

ghost locked as resolved and limited conversation to collaborators Jun 9, 2022

jeffhandley added area-System.Formats.Tar and removed area-System.IO labels Nov 21, 2022

	internal static SafeFileHandle Open(string fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, long preallocationSize,
	Interop.Sys.Permissions openPermissions = DefaultOpenPermissions,
	Func<Interop.ErrorInfo, Interop.Sys.OpenFlags, string, Exception?>? createOpenException = null)
	{
	return Open(fullPath, mode, access, share, options, preallocationSize, openPermissions, out _, out _, createOpenException);
	}


		_header = default;

		_header._extendedAttributes = new Dictionary<string, string>();

Implement Tar APIs #67883

Implement Tar APIs #67883

Conversation

carlossanlop commented Apr 12, 2022 • edited Loading

ghost commented Apr 12, 2022

dotnet-issue-labeler bot commented Apr 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danmoseley commented Apr 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlossanlop commented Apr 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmds commented Apr 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlossanlop Apr 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlossanlop commented Apr 21, 2022

adamsitnik left a comment

Choose a reason for hiding this comment

carlossanlop commented Apr 21, 2022

carlossanlop commented Apr 21, 2022

github-actions bot commented Apr 21, 2022

github-actions bot commented Apr 21, 2022

carlossanlop commented Apr 12, 2022 •

edited

Loading

carlossanlop commented Apr 14, 2022 •

edited

Loading

carlossanlop Apr 16, 2022 •

edited

Loading