dev: add curl to dockerfile #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,13 @@ LABEL description="Dojo is a provable game engine and toolchain for building onc | |||
| source="/~https://github.com/dojoengine/dojo" \ | |||
| documentation="https://book.dojoengine.org/" | |||
|
|
|||
| RUN apt-get -y update; \ | |||
There was a problem hiding this comment.
can you also move the ENV HEALTH_CHECK_PORT next to the HEALTHCHECK command? Generally speaking it's better to keep variable/declaration close to where they are used, and here it's not even in the final image if I'm right
There was a problem hiding this comment.
Gotcha, you're right, let me move it closer onto where it's used 👍
tarrencev
approved these changes
Jul 29, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this smol follow-up pr adds
curlto the final stage of the Dockerfile. Apologies, I misread it and thought it was included already