This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
dev: add docker healthcheck in compose #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
suggested changes
Jul 25, 2023
There was a problem hiding this comment.
lgtm, though I'd like to make sure that madara has no healthcheck route available first.
We should also add a healthcheck to katana, even though it's fast enough we actually want to make sure that we don't start the other containers until the "starknet" network is ready
ftupas
force-pushed
the
dev/add-healthcheck-madara
branch
from
e1e1109 to
4232be2
Compare
ftupas
commented
Jul 27, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
===========================================
+ Coverage 23.17% 73.25% +50.07%
===========================================
Files 9 30 +21
Lines 1247 2202 +955
===========================================
+ Hits 289 1613 +1324
+ Misses 958 589 -369
☔ View full report in Codecov by Sentry. |
ftupas
commented
Jul 27, 2023
ftupas
commented
Jul 27, 2023
Eikix
reviewed
Jul 27, 2023
Let me pin the image tag for dojo 👍 |
ftupas
commented
Jul 27, 2023
|
Alright great |
ClementWalter
previously approved these changes
Jul 28, 2023
ftupas
dismissed
ClementWalter’s stale review
The merge-base changed after approval.
ClementWalter
approved these changes
Jul 28, 2023
ClementWalter
previously approved these changes
Jul 28, 2023
ftupas
dismissed
ClementWalter’s stale review
The merge-base changed after approval.
ClementWalter
previously approved these changes
Jul 28, 2023
ftupas
dismissed
ClementWalter’s stale review
The merge-base changed after approval.
ClementWalter
previously approved these changes
Jul 28, 2023
ftupas
dismissed
ClementWalter’s stale review
The merge-base changed after approval.
ftupas
force-pushed
the
dev/add-healthcheck-madara
branch
from
b4ae6d3 to
85234cd
Compare
ftupas
commented
Jul 31, 2023
ClementWalter
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.01
Resolves: #337, #371
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Create a side-car container that does a healthcheck on the
starknetservice that it is ready to accept connections before deploying Kakarot contractsDoes this introduce a breaking change?