Remove pkg_resources usage #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #100 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 15 15
Lines 634 634
=======================================
Hits 555 555
Misses 79 79 ☔ View full report in Codecov by Sentry. |
luizirber
force-pushed
the
lirber/remove_pkg_resources
branch
2 times, most recently
from
af90b10 to
5cfc315
Compare
luizirber
force-pushed
the
lirber/remove_pkg_resources
branch
from
5cfc315 to
98796cf
Compare
ctb
approved these changes
Jan 12, 2023
luizirber
added a commit
to sourmash-bio/sourmash
that referenced
this pull request
Mar 5, 2023
Close #2491 Similar to dib-lab/screed#100 but also dealing with `entry_points` (and the differences in stdlib for [`importlib.metadata`](https://pypi.org/project/backports.entry-points-selectable/)...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resourcesis part ofsetuptools, so removing it allows not having a runtime dep onsetuptools. Its usage is also discouraged sinceimportlibhas the necessary features.https://setuptools.pypa.io/en/latest/pkg_resources.html
Declare
importlib_resourcesas a dependency for tests in 3.8 (since the.files()method was added in 3.9 stdlib)Update Read the Docs config to avoid the default 3.7 version.
Relevant to sourmash-bio/sourmash#2433 and NixOS/nixpkgs#205878