Remove pkg_resources usage #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizirber
commented
Mar 5, 2023
| @@ -78,7 +78,7 @@ dependencies = [ | |||
| "deprecation>=2.0.6", | |||
| "cachetools>=4,<6", | |||
| "bitstring>=3.1.9,<5", | |||
| "importlib_metadata;python_version<'3.10'" | |||
| "importlib_metadata>=3.6;python_version<'3.10'" | |||
There was a problem hiding this comment.
this is to avoid having behavior differences in importlib_metadata
Codecov Report
@@ Coverage Diff @@
## latest #2505 +/- ##
==========================================
+ Coverage 84.81% 92.58% +7.76%
==========================================
Files 133 104 -29
Lines 14820 12025 -2795
Branches 2513 2513
==========================================
- Hits 12570 11133 -1437
+ Misses 1948 590 -1358
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ctb
approved these changes
Mar 5, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2491
Similar to dib-lab/screed#100 but also dealing with
entry_points(and the differences in stdlib forimportlib.metadata...)