Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotnet Jobs SDK qs #1166

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Dotnet Jobs SDK qs #1166

merged 7 commits into from
Feb 27, 2025

Conversation

alicejgibbons
Copy link

@alicejgibbons alicejgibbons commented Feb 17, 2025

Description

The Dotnet SDK jobs quickstart. This is blocked on this bug being fixed: dapr/dotnet-sdk#1460

The tests WILL fail for now, until this bug is fixed and the README can be updated.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1114

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Alice Gibbons <alice@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
@rochabr
Copy link
Contributor

rochabr commented Feb 26, 2025

@WhitWaldo looks like the new SDK version fixes the initial issue that Alice mentioned, but the scheduled time(DueTime) is not being respected. The job runs immediately after scheduling.

== APP - job-service-sdk == Received invocation for the job R2-D2 with job data droid R2-D2
== APP - job-service-sdk == Starting droid: R2-D2
== APP - job-service-sdk == Executing maintenance job: Oil Change
== APP - job-service-sdk == Job Scheduled: R2-D2

The logs should have this order, when the scheduled time is respected:

== APP - job-service-sdk == Job Scheduled: R2-D2
== APP - job-service-sdk == Received invocation for the job R2-D2 with job data droid R2-D2
== APP - job-service-sdk == Starting droid: R2-D2
== APP - job-service-sdk == Executing maintenance job: Oil Change

This is the cron expression created from new CronExpressionBuilder().On(OnCronPeriod.Second, droidJob.DueTime): 15 * * * * *

Copy link
Contributor

@WhitWaldo WhitWaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package version updates needed

rochabr and others added 3 commits February 26, 2025 17:59
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
@alicejgibbons alicejgibbons marked this pull request as ready for review February 27, 2025 17:27
@alicejgibbons alicejgibbons requested review from a team as code owners February 27, 2025 17:27
Signed-off-by: Alice Gibbons <alice@diagrid.io>
@rochabr rochabr merged commit e87a963 into dapr:release-1.15 Feb 27, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants